You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/10/20 22:38:00 UTC

[GitHub] [commons-math] sritchie commented on a change in pull request #161: [MATH-1558] Fix MidPointIntegrator incremental implementation

sritchie commented on a change in pull request #161:
URL: https://github.com/apache/commons-math/pull/161#discussion_r508881160



##########
File path: src/test/java/org/apache/commons/math4/analysis/integration/MidPointIntegratorTest.java
##########
@@ -48,8 +67,9 @@ public void testLowAccuracy() {
         double expected = -3697001.0 / 48.0;
         double tolerance = FastMath.abs(expected * integrator.getRelativeAccuracy());
         double result = integrator.integrate(Integer.MAX_VALUE, f, min, max);
-        Assert.assertTrue(integrator.getEvaluations() < Integer.MAX_VALUE / 2);
+        Assert.assertTrue(integrator.getEvaluations() < Integer.MAX_VALUE / 3);

Review comment:
       This test might be redundant now that we know exactly how many evaluations we should have, as a function of iterations.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org