You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "codelipenghui (via GitHub)" <gi...@apache.org> on 2023/09/05 04:49:11 UTC
[GitHub] [pulsar] codelipenghui commented on pull request #20927: [fix][txn]Remove subscription after transaction pending ack init failed.
codelipenghui commented on PR #20927:
URL: https://github.com/apache/pulsar/pull/20927#issuecomment-1705935520
> During the process of creating a subscription, when checking if the transaction pending has been initialized using return store.exists(PREFIX + path);, a connection failure error occurred while connecting to ZooKeeper. However, the created subscription continues to exist in the PersistentTopic, which causes subsequent retries to keep using the same subscription.
@liangyepianzhou In such a scenario, the "subscribe" command should be deemed unsuccessful. The PendingAck module, being a part of the system, should focus solely on cleaning up its own state and subsequently notifying the caller of the failure it encountered. Then the caller("subscribe") should cleanup it's own state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org