You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/13 19:26:12 UTC

[GitHub] [superset] rusackas commented on a change in pull request #16252: chore: Improves the flow to create a new chart

rusackas commented on a change in pull request #16252:
URL: https://github.com/apache/superset/pull/16252#discussion_r688734426



##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -84,11 +81,54 @@ const StyledContainer = styled.div`
       & > span {
         color: ${theme.colors.grayscale.light1};
         margin-left: ${theme.gridUnit * 4}px;
-        margin-top: ${theme.gridUnit * 6}px;
       }
     }
 
-    & .ant-tooltip-open {
+    & .viz-gallery {
+      border: 1px solid ${theme.colors.grayscale.light2};
+      border-radius: ${theme.gridUnit}px;
+      margin: ${theme.gridUnit}px 0px;
+      max-height: calc(100vh - ${ELEMENTS_EXCEPT_VIZ_GALLERY}px);
+      flex: 1;
+    }
+
+    & .footer {
+      flex: 1;
+      display: flex;
+      flex-direction: row;
+      justify-content: flex-end;
+      align-items: center;
+
+      & > span {
+        color: ${theme.colors.grayscale.light1};
+        margin-right: ${theme.gridUnit * 4}px;
+      }
+    }
+
+    &&&& .ant-steps-item-tail {

Review comment:
       Yowza... the ampersand is a good hack, but this is another level! :) Still better than `!important`
   
   Not sure a way around it by looking, but maybe we can dig a little deeper later, and perhaps add a comment for now explaining why these are needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org