You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/28 13:07:13 UTC
[GitHub] flink pull request #4004: [FLINK-6695 Activate strict checkstyle in flink-co...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4004
[FLINK-6695 Activate strict checkstyle in flink-contrib
This PR activates the strict checkstyle for most modules in flink-contrib; `flink-tweet-inputformat` is not included due to proposal to remove it in FLINK-6710.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6695csctrb
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4004.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4004
----
commit f550ec204f5bab0a06b0ae8a078ee8a26b05a9e2
Author: zentol <ch...@apache.org>
Date: 2017-05-23T19:40:35Z
[FLINK-6695] Activate strict checkstyle for flink-connector-wikiedits
commit 41460d1da0632aab10af181678c2a4542b182895
Author: zentol <ch...@apache.org>
Date: 2017-05-23T20:05:19Z
[FLINK-6695] Activate strict checkstyle for flink-statebackend-rocksDB
commit 5789ac46c84e1329d6cf9c6ed7ff77b410242283
Author: zentol <ch...@apache.org>
Date: 2017-05-23T20:41:09Z
[FLINK-6695] Activate strict checkstyle for flink-storm
commit 326b997351217190c449d460ea447276434f57ba
Author: zentol <ch...@apache.org>
Date: 2017-05-23T21:47:00Z
[FLINK-6695] Activate strict checkstyle for flink-storm-examples
commit 62fc105e89334a27b5af5369948faa87f913120e
Author: zentol <ch...@apache.org>
Date: 2017-05-24T08:51:23Z
[FLINK-6695] Activate strict checkstyle for flink-streaming-contrib
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4004: [FLINK-6695] Activate strict checkstyle in flink-contrib
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4004
@greghogan fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4004: [FLINK-6695] Activate strict checkstyle in flink-contrib
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4004
@greghogan fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4004
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4004: [FLINK-6695] Activate strict checkstyle in flink-contrib
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4004
@greghogan did another attempt at fixing the issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4004#discussion_r118845592
--- Diff: flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/operators/VerifyAndEnrichBolt.java ---
@@ -27,6 +26,12 @@
import org.apache.storm.tuple.Tuple;
import org.apache.storm.tuple.Values;
+import java.util.Map;
+
+/**
+ * Verifies that incoming numbers are either even or odd, controlled by the constructor argument. Emitted tuples are
+ * enriched with a new string field containing either "even" or "odd", based on the numbers parity.
--- End diff --
numbers parity -> numbers' parity
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4004: [FLINK-6695] Activate strict checkstyle in flink-contrib
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4004
+1!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4004#discussion_r119082485
--- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/split/SplitBoltTopology.java ---
@@ -28,7 +28,7 @@
import org.apache.storm.topology.TopologyBuilder;
/**
- * A simple topology that splits a numbers stream based the numbers parity, and verifies the result.
+ * A simple topology that splits a numbers stream based their parity, and verifies the result.
--- End diff --
This would be a "number stream" or a "stream of numbers"? And I think "based on ...".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4004#discussion_r118845656
--- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/tests/operators/VerifyMetaDataBolt.java ---
@@ -28,6 +27,11 @@
import org.apache.storm.tuple.Tuple;
import org.apache.storm.tuple.Values;
+import java.util.Map;
+
+/**
+ * A Bolt implementation that verifies meta data emitted by a {@link MetaDataSpout}.
--- End diff --
I think that this should be "metadata" but see that the class is camelcased `MetaData`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4004#discussion_r118845633
--- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/split/SplitBoltTopology.java ---
@@ -15,23 +15,28 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.apache.flink.storm.split;
-import org.apache.storm.topology.TopologyBuilder;
import org.apache.flink.storm.split.operators.RandomSpout;
import org.apache.flink.storm.split.operators.VerifyAndEnrichBolt;
import org.apache.flink.storm.util.BoltFileSink;
import org.apache.flink.storm.util.BoltPrintSink;
import org.apache.flink.storm.util.OutputFormatter;
import org.apache.flink.storm.util.TupleOutputFormatter;
+import org.apache.storm.topology.TopologyBuilder;
+
+/**
+ * A simple topology that splits a number stream based the numbers parity, and verifies the result.
--- End diff --
numbers -> numbers'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4004#discussion_r118850095
--- Diff: flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/operators/VerifyAndEnrichBolt.java ---
@@ -30,7 +30,7 @@
/**
* Verifies that incoming numbers are either even or odd, controlled by the constructor argument. Emitted tuples are
- * enriched with a new string field containing either "even" or "odd", based on the numbers parity.
+ * enriched with a new string field containing either "even" or "odd", based on the numbers' parity.
--- End diff --
I think I got this wrong, too. Should probably be `number's`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4004#discussion_r118845646
--- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/tests/operators/FiniteRandomSpout.java ---
@@ -30,6 +28,13 @@
import org.apache.storm.tuple.Values;
import org.apache.storm.utils.Utils;
+import java.util.Map;
+import java.util.Random;
+
+/**
+ * A Spout implementation that broadcast random numbers across a specified number of output streams, until a specified
--- End diff --
"broadcast" -> "broadcasts"
"was" -> "is"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4004#discussion_r118850077
--- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/split/SplitBoltTopology.java ---
@@ -28,7 +28,7 @@
import org.apache.storm.topology.TopologyBuilder;
/**
- * A simple topology that splits a number stream based the numbers parity, and verifies the result.
+ * A simple topology that splits a numbers stream based the numbers parity, and verifies the result.
--- End diff --
What if we simplified this to "splits a number stream based on the parity"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4004#discussion_r118881170
--- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/split/SplitBoltTopology.java ---
@@ -28,7 +28,7 @@
import org.apache.storm.topology.TopologyBuilder;
/**
- * A simple topology that splits a number stream based the numbers parity, and verifies the result.
+ * A simple topology that splits a numbers stream based the numbers parity, and verifies the result.
--- End diff --
sounds better
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4004#discussion_r118881130
--- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/tests/operators/FiniteRandomSpout.java ---
@@ -32,8 +32,8 @@
import java.util.Random;
/**
- * A Spout implementation that broadcast random numbers across a specified number of output streams, until a specified
- * count was reached.
+ * A Spout implementation that broadcast randoms numbers across a specified number of output streams, until a specified
--- End diff --
wow. I really added the `s` to the wrong word...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4004#discussion_r118850085
--- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/tests/operators/FiniteRandomSpout.java ---
@@ -32,8 +32,8 @@
import java.util.Random;
/**
- * A Spout implementation that broadcast random numbers across a specified number of output streams, until a specified
- * count was reached.
+ * A Spout implementation that broadcast randoms numbers across a specified number of output streams, until a specified
--- End diff --
"broadcasts random"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4004: [FLINK-6695] Activate strict checkstyle in flink-contrib
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4004
YES! :D merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---