[jira] [Resolved] (HDFS-16847) RBF: StateStore writer should not commit tmp fail if there was an error in writing the file.

["Owen O'Malley (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-16847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley resolved HDFS-16847.
----------------------------------
    Fix Version/s: 3.4.0
                   3.3.5
       Resolution: Fixed

I committed this. Thanks, Simba!

> RBF: StateStore writer should not commit tmp fail if there was an error in writing the file.
> --------------------------------------------------------------------------------------------
>
>                 Key: HDFS-16847
>                 URL: https://issues.apache.org/jira/browse/HDFS-16847
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs, rbf
>            Reporter: Simbarashe Dzinamarira
>            Assignee: Simbarashe Dzinamarira
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 3.4.0, 3.3.5
>
>
> The file based implementation of the RBF state store has a commit step that moves a temporary file to a permanent location.
> There is a check to see if the write of the temp file was successfully, however, the code to commit doesn't check the success flag.
> This is the relevant code: [https://github.com/apache/hadoop/blob/7d39abd799a5f801a9fd07868a193205ab500bfa/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java#L369]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org