You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/27 19:54:43 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #7707: Remove the unnecessary "return;" at the end of function
xiaoxiang781216 opened a new pull request, #7707:
URL: https://github.com/apache/nuttx/pull/7707
## Summary
## Impact
code refactor only
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #7707: Remove the unnecessary "return;" at the end of function
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7707:
URL: https://github.com/apache/nuttx/pull/7707#issuecomment-1328423277
@masayuki2009 why CI doesn't catch this error? It look like CI fail to catch the build error several time recently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko merged pull request #7707: Remove the unnecessary "return;" at the end of function
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #7707:
URL: https://github.com/apache/nuttx/pull/7707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #7707: Remove the unnecessary "return;" at the end of function
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7707:
URL: https://github.com/apache/nuttx/pull/7707#issuecomment-1328378809
@xiaoxiang781216
Hmm, a build error happens with spresense:wifi.
```
CC: src/cxd56_crashdump.c
arm-none-eabi-gcc -c -Wstrict-prototypes -mabi=aapcs -Os -fno-strict-aliasing -fomit-frame-pointer -mthumb -fno-common -Wall -Wshadow -Wundef -ffunction-sections -fdata-sections -g -mlittle-endian -march=armv7e-m -mtune=cortex-m4 -mfpu=fpv4-sp-d16 -mfloat-abi=hard -isystem /mnt/m2ssd/opensource/github_masayuki2009/apache-nuttx-tmp/nuttx/include -D__NuttX__ -DNDEBUG -D__KERNEL__ -pipe -I "/mnt/m2ssd/opensource/github_masayuki2009/apache-nuttx-tmp/nuttx/arch/arm/src/board/board" -I "/mnt/m2ssd/opensource/github_masayuki2009/apache-nuttx-tmp/nuttx/arch/arm/src/board/src" -I "/mnt/m2ssd/opensource/github_masayuki2009/apache-nuttx-tmp/nuttx/sched" -I "/mnt/m2ssd/opensource/github_masayuki2009/apache-nuttx-tmp/nuttx/arch/arm/src/chip" -I "/mnt/m2ssd/opensource/github_masayuki2009/apache-nuttx-tmp/nuttx/arch/arm/src/common" -I "/mnt/m2ssd/opensource/github_masayuki2009/apache-nuttx-tmp/nuttx/arch/arm/src/armv7-m" src/cxd56_crashdump.c -o cxd56_crashdump.o
src/cxd56_crashdump.c: In function 'board_crashdump':
src/cxd56_crashdump.c:238:1: error: label at end of compound statement
238 | exit:
| ^~~~
/mnt/m2ssd/opensource/github_masayuki2009/apache-nuttx-tmp/nuttx/boards/Board.mk:83: recipe for target 'cxd56_crashdump.o' failed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org