[GitHub] [iceberg] rdblue commented on a change in pull request #3878: Docs: expire_snapshots documentation should mention or link to `history.expire.max-snapshot-age-ms` and `history.expire.min-snapshots-to-keep` table properties

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3878:
URL: https://github.com/apache/iceberg/pull/3878#discussion_r786310086



##########
File path: site/docs/spark-procedures.md
##########
@@ -183,6 +183,12 @@ and their files which are no longer needed.
 This procedure will remove old snapshots and data files which are uniquely required by those old snapshots. This means
 the `expire_snapshots` procedure will never remove files which are still required by a non-expired snapshot.
 
+Available [table behavior properties](./configuration#Table-behavior-properties) for `expire_snapshots`:

Review comment:
       I think that this should be shorter and not duplicate information at the linked location. Otherwise, we need to update it when the defaults change.
   
   This should also be combined with the Usage section below because that contains defaults that are determined by these settings.
   
   Instead of this paragraph, I would add one below the Usage table that states:
   
   > If `older_than` and `retain_last` are omitted, the table's [expiration properties](./configuration#Table-behavior-properties) will be used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org