You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by steveloughran <gi...@git.apache.org> on 2018/04/13 14:40:50 UTC

[GitHub] spark issue #21066: [SPARK-23977][CLOUD][WIP] Add commit protocol binding to...

Github user steveloughran commented on the issue:

    https://github.com/apache/spark/pull/21066
  
    RAT test was on a 0-byte .keep file in `src/test/scala` as the maven plugging adding a profile-specific test source path needs an original one.
    
    easiest fix is just to add a real scala file in the source tree, with an ASF comment. I don't want to add explicit instantiation tests (e.g new S3AFileSystem()), because of some CP conflict between S3AFS on Hadoop 2.8 and spark's own CP: risk of failing on some test setups. It's a legit failure, but...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org