You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/30 15:37:12 UTC

[jira] [Commented] (SLING-5752) SimpleHttpDistributionTransport does not leverage configured scheme from distribution endpoint

    [ https://issues.apache.org/jira/browse/SLING-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306766#comment-15306766 ] 

ASF GitHub Bot commented on SLING-5752:
---------------------------------------

GitHub user tmaret opened a pull request:

    https://github.com/apache/sling/pull/144

    SLING-5752 - SimpleHttpDistributionTransport does not leverage configured scheme from distribution endpoint

    * Pass scheme from distribution endpoint when building Executor's HttpHost

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tmaret/sling SLING-5752

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sling/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #144
    
----
commit e876de40c51cbcbc2f0aac41f3e0607b7c0c6ca2
Author: tmaret <tm...@adobe.com>
Date:   2016-05-30T15:34:30Z

    SLING-5752 - SimpleHttpDistributionTransport does not leverage configured scheme from distribution endpoint
    
    * Pass scheme from distribution endpoint when building Executor's HttpHost

----


> SimpleHttpDistributionTransport does not leverage configured scheme from distribution endpoint
> ----------------------------------------------------------------------------------------------
>
>                 Key: SLING-5752
>                 URL: https://issues.apache.org/jira/browse/SLING-5752
>             Project: Sling
>          Issue Type: Bug
>          Components: Distribution, Extensions
>    Affects Versions: Content Distribution Core 0.1.16
>            Reporter: Timothee Maret
>            Assignee: Timothee Maret
>             Fix For: Content Distribution Core 0.1.18
>
>
> {{SimpleHttpDistributionTransport}} currently does not allow to communicate with a distribution endpoint using {{https://}} scheme. The root cause is that the method {{org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport#authenticate}} does hardcode the scheme instead of setting it from the configured {{distributionEndpoint}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)