You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/05/20 10:41:55 UTC

[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #989: SCB-2176 Refactor websocket (#986)

tianxiaoliang commented on a change in pull request #989:
URL: https://github.com/apache/servicecomb-service-center/pull/989#discussion_r635983570



##########
File path: server/event/instance_subscriber.go
##########
@@ -18,12 +18,13 @@
 package event
 
 import (
+	"fmt"
 	"github.com/apache/servicecomb-service-center/pkg/event"
 	"github.com/apache/servicecomb-service-center/pkg/log"
-	"time"
+	"github.com/apache/servicecomb-service-center/server/connection"
 )
 
-const AddJobTimeout = 1 * time.Second
+var errBusy = fmt.Errorf("too busy")

Review comment:
       没必要用fmt

##########
File path: server/connection/ws/websocket.go
##########
@@ -29,6 +29,8 @@ import (
 
 const Websocket = "Websocket"
 
+var errServiceNotExist = fmt.Errorf("Service does not exist.")

Review comment:
       开头小写




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org