You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2021/05/31 08:39:36 UTC

[GitHub] [incubator-pegasus] hycdong commented on a change in pull request #741: feat: add hashkey pattern rule

hycdong commented on a change in pull request #741:
URL: https://github.com/apache/incubator-pegasus/pull/741#discussion_r642317120



##########
File path: src/server/compaction_filter_rule.h
##########
@@ -36,5 +38,34 @@ class compaction_filter_rule
                        const std::string &sort_key,
                        const rocksdb::Slice &existing_value) const = 0;
 };
+
+enum string_match_type
+{
+    SMT_MATCH_ANYWHERE,
+    SMT_MATCH_PREFIX,
+    SMT_MATCH_POSTFIX,
+    SMT_INVALID,
+};
+ENUM_BEGIN(string_match_type, SMT_INVALID)
+ENUM_REG(SMT_MATCH_ANYWHERE)
+ENUM_REG(SMT_MATCH_PREFIX)
+ENUM_REG(SMT_MATCH_POSTFIX)
+ENUM_END(string_match_type)
+
+class hashkey_pattern_rule : public compaction_filter_rule
+{
+public:
+    explicit hashkey_pattern_rule(uint32_t pegasus_data_version);

Review comment:
       Why do hashkey pattern need `pegasus_data_version`? Is `pegasus_data_version` used for value schema?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org