You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/06/19 11:07:17 UTC
[GitHub] codecov-io edited a comment on issue #3777: Avoid converting
ByteString to bytes in attachment inlining flow
codecov-io edited a comment on issue #3777: Avoid converting ByteString to bytes in attachment inlining flow
URL: https://github.com/apache/incubator-openwhisk/pull/3777#issuecomment-398009157
# [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr&el=h1) Report
> Merging [#3777](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/59ba42b577f9c8b7c7911da26ee9bae9d5e4d1a2?src=pr&el=desc) will **increase** coverage by `1.13%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3777 +/- ##
==========================================
+ Coverage 74.01% 75.15% +1.13%
==========================================
Files 132 132
Lines 6181 6141 -40
Branches 385 374 -11
==========================================
+ Hits 4575 4615 +40
+ Misses 1606 1526 -80
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...isk/core/database/memory/MemoryArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUFydGlmYWN0U3RvcmUuc2NhbGE=) | `99.18% <100%> (+2.73%)` | :arrow_up: |
| [...n/scala/whisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==) | `73.23% <100%> (+2.45%)` | :arrow_up: |
| [...k/core/database/memory/MemoryAttachmentStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUF0dGFjaG1lbnRTdG9yZS5zY2FsYQ==) | `95% <100%> (+0.26%)` | :arrow_up: |
| [.../scala/whisk/core/database/AttachmentSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQXR0YWNobWVudFN1cHBvcnQuc2NhbGE=) | `100% <100%> (ø)` | |
| [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `89.77% <0%> (+1.13%)` | :arrow_up: |
| [...ain/scala/whisk/core/entity/ActivationResult.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25SZXN1bHQuc2NhbGE=) | `92.3% <0%> (+1.53%)` | :arrow_up: |
| [...in/scala/whisk/utils/ExecutionContextFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL3V0aWxzL0V4ZWN1dGlvbkNvbnRleHRGYWN0b3J5LnNjYWxh) | `100% <0%> (+7.69%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr&el=footer). Last update [59ba42b...32d73ee](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services