You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@distributedlog.apache.org by brennonyork <gi...@git.apache.org> on 2016/12/16 19:44:32 UTC
[GitHub] incubator-distributedlog pull request #77: DL-122: Use assertions from Junit...
GitHub user brennonyork opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/77
DL-122: Use assertions from Junit rather than assert() for tests
* changed all instances of `assert()` to junit versions in `src/test`
Here is the script I used to find all instances of `assert()` inside the `src/test` folder:
```
grep -r "assert(" * 2>/dev/null | grep -v "main"
```
The `grep -v "main"` removes all instances of the usage within the main source tree (which there are quite a few). I did this as I assumed the JIRA ticket spirit was not to remove those instances from the main tree and thus would require including `junit` in core compilation rather than scoped for `test` as is.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brennonyork/incubator-distributedlog DL-122
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit d95c57afe627f73b0e98a0a6b11db59f07eccfd5
Author: Brennon York <br...@capitalone.com>
Date: 2016-12-16T19:38:20Z
changed all instances of assert() to junit versions in src/test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog issue #77: DL-122: Use assertions from Junit rather...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/77
@brennonyork I think it is a common issue for a few tests that are kind of time dependent. so travis ci will run two jobs and the apache jenkins will run another one. they run same mvn command. if any of one passed the verification, it typically means that this change is safe. so in your pull request, one of travis CI passed and the jenkins also passed, so your change seems to be safe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog pull request #77: DL-122: Use assertions from Junit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-distributedlog/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog issue #77: DL-122: Use assertions from Junit rather...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/77
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---