You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/16 18:55:53 UTC
[GitHub] [spark] srowen opened a new pull request, #36226: [SPARK-38924][UI] Update datatables to 1.10.25
srowen opened a new pull request, #36226:
URL: https://github.com/apache/spark/pull/36226
### What changes were proposed in this pull request?
Update javascript library datatables, used in the UI, to 1.10.25
### Why are the changes needed?
https://nvd.nist.gov/vuln/detail/CVE-2020-28458 affects the current version of datatables, 1.10.20, and would be safer to just update.
### Does this PR introduce _any_ user-facing change?
Should not.
### How was this patch tested?
Existing tests, with some minor manual local testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36226: [SPARK-38924][UI] Update datatables to 1.10.25
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36226:
URL: https://github.com/apache/spark/pull/36226#issuecomment-1100781511
cc @gengliangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #36226: [SPARK-38924][UI] Update datatables to 1.10.25
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #36226: [SPARK-38924][UI] Update datatables to 1.10.25
URL: https://github.com/apache/spark/pull/36226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maytasm commented on pull request #36226: [SPARK-38924][UI] Update datatables to 1.10.25
Posted by "maytasm (via GitHub)" <gi...@apache.org>.
maytasm commented on PR #36226:
URL: https://github.com/apache/spark/pull/36226#issuecomment-1530789474
@gengliangwang @srowen looks like this change broke the sorting arrow on the table. The sort_asc.png and sort_ desc.png is not displayed in the table. I believe this is because the jquery.dataTables.1.10.25.min.css uses `!important` for the sort_asc.png and sort_ desc.png
i.e. `.sorting_asc{background-image:url("../images/sort_asc.png") !important`
Seems like this is not a problem in master branch as we upgraded DataTables from 1.10.25 to 1.13.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #36226: [SPARK-38924][UI] Update datatables to 1.10.25
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #36226:
URL: https://github.com/apache/spark/pull/36226#issuecomment-1100810575
It seems that we need to update the style of "Show ... entries" in stage/executor page.
Before changes(spark 3.2):
<img width="235" alt="image" src="https://user-images.githubusercontent.com/1097932/163702591-99551bce-40c6-4d0e-aaf9-ff047897895f.png">
After changes:
<img width="185" alt="image" src="https://user-images.githubusercontent.com/1097932/163702597-9105b67f-aa6f-43fd-b5ec-3ea110b5609d.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maytasm commented on pull request #36226: [SPARK-38924][UI] Update datatables to 1.10.25
Posted by "maytasm (via GitHub)" <gi...@apache.org>.
maytasm commented on PR #36226:
URL: https://github.com/apache/spark/pull/36226#issuecomment-1530899078
@srowen I verified that upgrading DataTables to 1.13.2 fixes the issue with missing asc/desc arrows. See image:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #36226: [SPARK-38924][UI] Update datatables to 1.10.25
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #36226:
URL: https://github.com/apache/spark/pull/36226#issuecomment-1100903973
Good catch. I pushed a change that seems to override and fix the select, though it is now 100% width and renders a bit wider. Doesn't seem to hurt though, and I couldn't figure out another CSS setting that worked
<img width="293" alt="Screen Shot 2022-04-17 at 09 48 41" src="https://user-images.githubusercontent.com/822522/163721912-93027e1d-f73e-41df-bc8d-13582cec69bf.png">
!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #36226: [SPARK-38924][UI] Update datatables to 1.10.25
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #36226:
URL: https://github.com/apache/spark/pull/36226#issuecomment-1100928173
@srowen Thanks for the fix. Merging to master/3.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maytasm commented on pull request #36226: [SPARK-38924][UI] Update datatables to 1.10.25
Posted by "maytasm (via GitHub)" <gi...@apache.org>.
maytasm commented on PR #36226:
URL: https://github.com/apache/spark/pull/36226#issuecomment-1530899374
I think we can backport [SPARK-42435](https://issues.apache.org/jira/browse/SPARK-42435) to 3.3 and 3.4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #36226: [SPARK-38924][UI] Update datatables to 1.10.25
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #36226:
URL: https://github.com/apache/spark/pull/36226#issuecomment-1530791323
Ooh, OK. do you know of a clean fix for the older branches to restore the arrows? If 1.13.2 works again, then we could also consider back-porting that update too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org