You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/04/01 02:48:27 UTC
[GitHub] [mynewt-core] benmccrea opened a new pull request #2257: sys/id:
Add optional id/serial_mfg field for storing manufacturer serial number
benmccrea opened a new pull request #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number
URL: https://github.com/apache/mynewt-core/pull/2257
This PR adds a new optional field, id/serial_mfg to be used for alternate serial numbers on devices during the manufacturing process.
The syscfg ID_SERIAL_MFG_PRESENT is disabled by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2257: sys/id:
Add optional id/serial_mfg field for storing manufacturer serial number
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number
URL: https://github.com/apache/mynewt-core/pull/2257#issuecomment-606996564
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### sys/id/include/id/id.h
<details>
```diff
@@ -25,19 +25,19 @@
#endif
#if MYNEWT_VAL(ID_SERIAL_PRESENT)
- /*
- * Maximum expected serial number string length.
- */
+/*
+ * Maximum expected serial number string length.
+ */
#define ID_SERIAL_MAX_LEN MYNEWT_VAL(ID_SERIAL_MAX_LEN)
- extern char id_serial[];
+extern char id_serial[];
#endif
#if MYNEWT_VAL(ID_SERIAL_MFG_PRESENT)
- /*
- * Maximum expected serial_mfg number string length.
- */
+/*
+ * Maximum expected serial_mfg number string length.
+ */
#define ID_SERIAL_MFG_MAX_LEN MYNEWT_VAL(ID_SERIAL_MFG_MAX_LEN)
- extern char id_serial_mfg[];
+extern char id_serial_mfg[];
#endif
#if MYNEWT_VAL(ID_MANUFACTURER_LOCAL)
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2257: sys/id:
Add optional id/serial_mfg field for storing manufacturer serial number
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number
URL: https://github.com/apache/mynewt-core/pull/2257#issuecomment-606999280
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] benmccrea merged pull request #2257: sys/id: Add
optional id/serial_mfg field for storing manufacturer serial number
Posted by GitBox <gi...@apache.org>.
benmccrea merged pull request #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number
URL: https://github.com/apache/mynewt-core/pull/2257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2257:
sys/id: Add optional id/serial_mfg field for storing manufacturer serial
number
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number
URL: https://github.com/apache/mynewt-core/pull/2257#issuecomment-606996564
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### sys/id/include/id/id.h
<details>
```diff
@@ -25,19 +25,19 @@
#endif
#if MYNEWT_VAL(ID_SERIAL_PRESENT)
- /*
- * Maximum expected serial number string length.
- */
+/*
+ * Maximum expected serial number string length.
+ */
#define ID_SERIAL_MAX_LEN MYNEWT_VAL(ID_SERIAL_MAX_LEN)
- extern char id_serial[];
+extern char id_serial[];
#endif
#if MYNEWT_VAL(ID_SERIAL_MFG_PRESENT)
- /*
- * Maximum expected serial_mfg number string length.
- */
+/*
+ * Maximum expected serial_mfg number string length.
+ */
#define ID_SERIAL_MFG_MAX_LEN MYNEWT_VAL(ID_SERIAL_MFG_MAX_LEN)
- extern char id_serial_mfg[];
+extern char id_serial_mfg[];
#endif
#if MYNEWT_VAL(ID_MANUFACTURER_LOCAL)
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services