You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by ly...@apache.org on 2023/12/05 03:26:07 UTC
(incubator-devlake) branch main updated: fix: github issue data too long for column type (#6560)
This is an automated email from the ASF dual-hosted git repository.
lynwee pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
The following commit(s) were added to refs/heads/main by this push:
new 03e70d0b8 fix: github issue data too long for column type (#6560)
03e70d0b8 is described below
commit 03e70d0b8e7b0e8f21e3b6ea27147e01561fe041
Author: abeizn <zi...@merico.dev>
AuthorDate: Tue Dec 5 11:26:02 2023 +0800
fix: github issue data too long for column type (#6560)
---
backend/core/models/domainlayer/ticket/issue.go | 2 +-
.../20231205_modify_issue_original_type_length.go} | 50 +++++++++++-----------
backend/core/models/migrationscripts/register.go | 1 +
backend/plugins/github/models/issue.go | 5 ++-
...ter.go => 20231205_modify_issue_type_length.go} | 50 +++++++++++-----------
.../github/models/migrationscripts/register.go | 1 +
6 files changed, 54 insertions(+), 55 deletions(-)
diff --git a/backend/core/models/domainlayer/ticket/issue.go b/backend/core/models/domainlayer/ticket/issue.go
index 977ea69ed..1ef02d4a6 100644
--- a/backend/core/models/domainlayer/ticket/issue.go
+++ b/backend/core/models/domainlayer/ticket/issue.go
@@ -32,7 +32,7 @@ type Issue struct {
Description string
EpicKey string `gorm:"type:varchar(255)"`
Type string `gorm:"type:varchar(100)"`
- OriginalType string `gorm:"type:varchar(100)"`
+ OriginalType string `gorm:"type:varchar(500)"`
Status string `gorm:"type:varchar(100)"`
OriginalStatus string `gorm:"type:varchar(100)"`
StoryPoint float64
diff --git a/backend/plugins/github/models/migrationscripts/register.go b/backend/core/models/migrationscripts/20231205_modify_issue_original_type_length.go
similarity index 52%
copy from backend/plugins/github/models/migrationscripts/register.go
copy to backend/core/models/migrationscripts/20231205_modify_issue_original_type_length.go
index deac0d93d..ab2df6a36 100644
--- a/backend/plugins/github/models/migrationscripts/register.go
+++ b/backend/core/models/migrationscripts/20231205_modify_issue_original_type_length.go
@@ -18,33 +18,31 @@ limitations under the License.
package migrationscripts
import (
+ "github.com/apache/incubator-devlake/core/context"
+ "github.com/apache/incubator-devlake/core/errors"
"github.com/apache/incubator-devlake/core/plugin"
)
-// All return all the migration scripts
-func All() []plugin.MigrationScript {
- return []plugin.MigrationScript{
- new(addInitTables),
- new(addGithubRunsTable),
- new(addGithubJobsTable),
- new(addGithubPipelineTable),
- new(deleteGithubPipelineTable),
- new(addHeadRepoIdFieldInGithubPr),
- new(addEnableGraphqlForConnection),
- new(addTransformationRule20221124),
- new(concatOwnerAndName),
- new(addStdTypeToIssue221230),
- new(addConnectionIdToTransformationRule),
- new(addEnvToRunAndJob),
- new(addGithubCommitAuthorInfo),
- new(fixRunNameToText),
- new(addGithubMultiAuth),
- new(renameTr2ScopeConfig),
- new(addGithubIssueAssignee),
- new(addFullName),
- new(addRawParamTableForScope),
- new(addDeploymentTable),
- new(modifyGithubMilestone),
- new(addEnvNamePattern),
- }
+var _ plugin.MigrationScript = (*modifyIssueOriginalTypeLength)(nil)
+
+type modifyIssueOriginalTypeLength struct{}
+
+type issue20231205 struct {
+ OriginalType string `gorm:"type:varchar(500)"`
+}
+
+func (issue20231205) TableName() string {
+ return "issues"
+}
+
+func (script *modifyIssueOriginalTypeLength) Up(basicRes context.BasicRes) errors.Error {
+ return basicRes.GetDal().AutoMigrate(&issue20231205{})
+}
+
+func (*modifyIssueOriginalTypeLength) Version() uint64 {
+ return 20231205155129
+}
+
+func (*modifyIssueOriginalTypeLength) Name() string {
+ return "modify issues original_type length from 100 to 500"
}
diff --git a/backend/core/models/migrationscripts/register.go b/backend/core/models/migrationscripts/register.go
index 3ddf4205c..ce92add2b 100644
--- a/backend/core/models/migrationscripts/register.go
+++ b/backend/core/models/migrationscripts/register.go
@@ -101,5 +101,6 @@ func All() []plugin.MigrationScript {
new(addOriginalStatusAndResultToDevOpsTables),
new(addQueuedDurationSecFieldToDevopsTables),
new(addCommitMsg),
+ new(modifyIssueOriginalTypeLength),
}
}
diff --git a/backend/plugins/github/models/issue.go b/backend/plugins/github/models/issue.go
index 34808899a..34be4d42f 100644
--- a/backend/plugins/github/models/issue.go
+++ b/backend/plugins/github/models/issue.go
@@ -18,8 +18,9 @@ limitations under the License.
package models
import (
- "github.com/apache/incubator-devlake/core/models/common"
"time"
+
+ "github.com/apache/incubator-devlake/core/models/common"
)
type GithubIssue struct {
@@ -31,7 +32,7 @@ type GithubIssue struct {
Title string
Body string
Priority string `gorm:"type:varchar(255)"`
- Type string `gorm:"type:varchar(100)"`
+ Type string `gorm:"type:varchar(500)"`
StdType string `gorm:"type:varchar(100)"`
AuthorId int
AuthorName string `gorm:"type:varchar(255)"`
diff --git a/backend/plugins/github/models/migrationscripts/register.go b/backend/plugins/github/models/migrationscripts/20231205_modify_issue_type_length.go
similarity index 52%
copy from backend/plugins/github/models/migrationscripts/register.go
copy to backend/plugins/github/models/migrationscripts/20231205_modify_issue_type_length.go
index deac0d93d..edeb1b2b8 100644
--- a/backend/plugins/github/models/migrationscripts/register.go
+++ b/backend/plugins/github/models/migrationscripts/20231205_modify_issue_type_length.go
@@ -18,33 +18,31 @@ limitations under the License.
package migrationscripts
import (
+ "github.com/apache/incubator-devlake/core/context"
+ "github.com/apache/incubator-devlake/core/errors"
"github.com/apache/incubator-devlake/core/plugin"
)
-// All return all the migration scripts
-func All() []plugin.MigrationScript {
- return []plugin.MigrationScript{
- new(addInitTables),
- new(addGithubRunsTable),
- new(addGithubJobsTable),
- new(addGithubPipelineTable),
- new(deleteGithubPipelineTable),
- new(addHeadRepoIdFieldInGithubPr),
- new(addEnableGraphqlForConnection),
- new(addTransformationRule20221124),
- new(concatOwnerAndName),
- new(addStdTypeToIssue221230),
- new(addConnectionIdToTransformationRule),
- new(addEnvToRunAndJob),
- new(addGithubCommitAuthorInfo),
- new(fixRunNameToText),
- new(addGithubMultiAuth),
- new(renameTr2ScopeConfig),
- new(addGithubIssueAssignee),
- new(addFullName),
- new(addRawParamTableForScope),
- new(addDeploymentTable),
- new(modifyGithubMilestone),
- new(addEnvNamePattern),
- }
+var _ plugin.MigrationScript = (*modifyIssueTypeLength)(nil)
+
+type modifyIssueTypeLength struct{}
+
+type issue20231205 struct {
+ Type string `gorm:"type:varchar(500)"`
+}
+
+func (issue20231205) TableName() string {
+ return "_tool_github_issues"
+}
+
+func (script *modifyIssueTypeLength) Up(basicRes context.BasicRes) errors.Error {
+ return basicRes.GetDal().AutoMigrate(&issue20231205{})
+}
+
+func (*modifyIssueTypeLength) Version() uint64 {
+ return 20231205145125
+}
+
+func (*modifyIssueTypeLength) Name() string {
+ return "modify github issue type length from 100 to 500"
}
diff --git a/backend/plugins/github/models/migrationscripts/register.go b/backend/plugins/github/models/migrationscripts/register.go
index deac0d93d..a179a1bfd 100644
--- a/backend/plugins/github/models/migrationscripts/register.go
+++ b/backend/plugins/github/models/migrationscripts/register.go
@@ -46,5 +46,6 @@ func All() []plugin.MigrationScript {
new(addDeploymentTable),
new(modifyGithubMilestone),
new(addEnvNamePattern),
+ new(modifyIssueTypeLength),
}
}