You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/11/29 17:38:56 UTC
[GitHub] [accumulo] keith-turner opened a new issue #2371: listSplits table operation with a max num splits may have a bug.
keith-turner opened a new issue #2371:
URL: https://github.com/apache/accumulo/issues/2371
In the following code there is a while loop, however in the while loop the variable `i` does not change which seems like a bug. If the while loop will execute more than once then it will add the same split multiple times which seems like a bug.
https://github.com/apache/accumulo/blob/45a4a93d2926760d6a916ae2da1d7e668ec4dcb1/core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java#L706-L710
Not completely sure if the while loop could execute more than once, needs further investigation. If the outer variable `r` could be greater than 1, then it seems like the while loop could execute more than once.
If the while loop could never execute more than once then maybe it could be changed to an if stmt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jmark99 closed issue #2371: listSplits table operation with a max num splits may have a bug.
Posted by GitBox <gi...@apache.org>.
jmark99 closed issue #2371:
URL: https://github.com/apache/accumulo/issues/2371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jmark99 commented on issue #2371: listSplits table operation with a max num splits may have a bug.
Posted by GitBox <gi...@apache.org>.
jmark99 commented on issue #2371:
URL: https://github.com/apache/accumulo/issues/2371#issuecomment-982984779
I was looking at the code today. The value of 'r' will always be <= 1 so the while-loop should never execute more than one time per for-loop iteration. Switching the while-loop to an if-statement would not affect results while perhaps clearing up the code a small amount. Either way, the code accomplishes its intended purpose at the moment.
As for this particular ticket, three options can be considered:
* leaving correctly running code as is
* updating the while-loop to an if-statement to remove a small amount of confusion
* look into other methods of evenly parsing data as referenced above.
Thoughts on this ticket in particular?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on issue #2371: listSplits table operation with a max num splits may have a bug.
Posted by GitBox <gi...@apache.org>.
milleruntime commented on issue #2371:
URL: https://github.com/apache/accumulo/issues/2371#issuecomment-982988109
> updating the while-loop to an if-statement to remove a small amount of confusion
The code is confusing so I think this could at least be done to clear up any confusion and confirm there isn't an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on issue #2371: listSplits table operation with a max num splits may have a bug.
Posted by GitBox <gi...@apache.org>.
milleruntime commented on issue #2371:
URL: https://github.com/apache/accumulo/issues/2371#issuecomment-982974602
I was talking with @ctubbsii a bit about some of the issues the many different use cases that can be encountered with splitting data evenly and the work I was doing for #2368. Instead of us trying to write our own algorithms, maybe we can use a library. He suggested taking a look at the Apache Datasketches project, for help with mathematical algorthims such as this. One type in particular that might be useful is the quantiles in ItemsSketch: https://datasketches.apache.org/api/java/snapshot/apidocs/org/apache/datasketches/quantiles/ItemsSketch.html#getQuantiles-int-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org