You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/25 03:11:06 UTC

[GitHub] [beam] tvalentyn commented on a change in pull request #12239: [BEAM-9980] tests tied with Python versions configurable

tvalentyn commented on a change in pull request #12239:
URL: https://github.com/apache/beam/pull/12239#discussion_r458295913



##########
File path: build.gradle
##########
@@ -243,13 +241,16 @@ task pythonFormatterPreCommit() {
   dependsOn 'sdks:python:test-suites:tox:py38:formatter'
 }
 
+task pythonPostCommit() {

Review comment:
       I am not sure I understand which suites we include in this postcommit suite and how we select which version are high priority.

##########
File path: sdks/python/test-suites/gradle.properties
##########
@@ -0,0 +1,39 @@
+################################################################################
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+# Following properties define which Python versions be used when the tests running.
+# Versions must be indicated major and minor versions connected with period.
+# And if you want to use multiple versions, concat them with comma and no whitespace.
+
+# dataflow test-suites

Review comment:
       This is a great chaos reduction in our test suite! This would be super helpful for Python 2 deprecation.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org