You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/06/06 04:03:00 UTC
[jira] [Commented] (IMPALA-12059) Make Thrift compilation stop spewing warnings
[ https://issues.apache.org/jira/browse/IMPALA-12059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729579#comment-17729579 ]
ASF subversion and git services commented on IMPALA-12059:
----------------------------------------------------------
Commit 4cf0bfa83f9641eb95d83c76af7962e6a3f1e064 in impala's branch refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=4cf0bfa83 ]
IMPALA-12059: Deduplicate and filter warnings from Thrift compilation
This wraps Thrift compilation commands with the
bin/thrift-quiet-wrapper.sh shell script. This script runs the
Thrift compilation command, collecting the output. If the
command fails, it dumps the output as-is. If the command succeeds,
it deduplicates the warnings and filters out a couple warnings
that we have no intention of fixing.
Testing:
- Ran "make gen-deps" on a clean build and verified that
the Thrift warnings are deduplicated and filtered
- Modified a Thrift file and verified errors are printed as-is.
Change-Id: I7b912ac3d57d1a51e957889b5798dc05d156a3d0
Reviewed-on: http://gerrit.cloudera.org:8080/19818
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Make Thrift compilation stop spewing warnings
> ---------------------------------------------
>
> Key: IMPALA-12059
> URL: https://issues.apache.org/jira/browse/IMPALA-12059
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 4.3.0
> Reporter: Joe McDonnell
> Priority: Major
>
> Thrift compilation produces enormous output due to warnings that are repeated countless times. Most of the warnings are worthless, so we should just filter them out rather than printing them to the console. There are a mixture of warnings that we have no intention of addressing and warnings that come from non-Impala thrift files.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org