You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2016/01/08 03:55:40 UTC
[jira] [Commented] (HBASE-15080) Remove synchronized block from
MasterServiceStubMaker#releaseZooKeeperWatcher()
[ https://issues.apache.org/jira/browse/HBASE-15080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088621#comment-15088621 ]
Josh Elser commented on HBASE-15080:
------------------------------------
Looks right given what you and I talked about earlier, Ted!
Thanks for posting a patch.
> Remove synchronized block from MasterServiceStubMaker#releaseZooKeeperWatcher()
> -------------------------------------------------------------------------------
>
> Key: HBASE-15080
> URL: https://issues.apache.org/jira/browse/HBASE-15080
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.98.17
>
> Attachments: 15080-0.98.txt
>
>
> This is a follow up to HBASE-11460
> [~elserj] found that in 0.98, the synchronized block below should have been taken out (as was done for branch-1 +):
> {code}
> synchronized (masterAndZKLock) {
> if (keepAliveZookeeperUserCount.decrementAndGet() <= 0 ){
> {code}
> keepAliveZookeeperUserCount is an AtomicInteger. There is no need for the synchronized block.
> This issue is to remove the synchronized block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)