[jira] [Commented] (MAPREDUCE-3154) Validate the Jobs Output Specification as the first statement in JobSubmitter.submitJobInternal(Job, Cluster) method

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122998#comment-13122998 ] 

Hadoop QA commented on MAPREDUCE-3154:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12498193/MAPREDUCE-3154.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/967//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/967//console

This message is automatically generated.
                
> Validate the Jobs Output Specification as the first statement in JobSubmitter.submitJobInternal(Job, Cluster) method
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3154
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3154
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: client, mrv2
>    Affects Versions: 0.23.0, 0.24.0
>         Environment: mrv2
>            Reporter: Abhijit Suresh Shingate
>            Assignee: Abhijit Suresh Shingate
>         Attachments: MAPREDUCE-3154.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Presently the output specification is validated after getting new JobId from ClientRMService, Copying the job jar, Configuration file, archives etc.
> Instead of that move following Job Output specification validation call to the begining of JobSubmitter.submitJobInternal(Job, Cluster) method.
> {code}
> checkSpecs(job);
> {code}
> This will avoid unnecessary work in case of invalid output specs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira