You are viewing a plain text version of this content. The canonical link for it is here.

Posted to batik-dev@xmlgraphics.apache.org by bu...@apache.org on 2008/11/06 04:55:19 UTC

DO NOT REPLY [Bug 46124] AnimationEngine.removeAnimation doesn't clean up the "animation sandwich" correctly.

https://issues.apache.org/bugzilla/show_bug.cgi?id=46124


Cameron McCormack <ca...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Cameron McCormack <ca...@apache.org>  2008-11-05 19:55:18 PST ---
Hi Steve and Helder.

Thanks for the bug report, and the attached patch and test.  The proposed
solution doesn't completely solve the bug, however.  When an animation is
removed, its effect needs to be removed also.  This is meant to be achieved by
leaving the Sandwich object in there, with no animations in it but with
shouldUpdate = true.

The ANIM_TYPE_OTHER case is just missing a check in tick() to ensure
sandwich.animation is not null (as is checked for XML/CSS animations earlier in
the method).

This is now fixed in r711765 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=711765 ).


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org