You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/20 17:07:46 UTC
[GitHub] [arrow] mbrubeck opened a new pull request #9277: [Rust] Don't rerun build.rs on every file change
mbrubeck opened a new pull request #9277:
URL: https://github.com/apache/arrow/pull/9277
This speeds up development by avoiding rebuilding the whole library
when any file in the package directory is touched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9277: [Rust] Don't rerun build.rs on every file change
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9277:
URL: https://github.com/apache/arrow/pull/9277#issuecomment-763808991
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9277: ARROW-11329: [Rust] Don't rerun build.rs on every file change
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9277:
URL: https://github.com/apache/arrow/pull/9277#issuecomment-763817914
https://issues.apache.org/jira/browse/ARROW-11329
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #9277: ARROW-11329: [Rust] Don't rerun build.rs on every file change
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #9277:
URL: https://github.com/apache/arrow/pull/9277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9277: ARROW-11329: [Rust] Don't rerun build.rs on every file change
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9277:
URL: https://github.com/apache/arrow/pull/9277#issuecomment-763823687
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9277?src=pr&el=h1) Report
> Merging [#9277](https://codecov.io/gh/apache/arrow/pull/9277?src=pr&el=desc) (c636cf1) into [master](https://codecov.io/gh/apache/arrow/commit/691286975f277f00586cabc6d834ff1efd8caf8c?el=desc) (6912869) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9277?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9277 +/- ##
==========================================
- Coverage 81.68% 81.65% -0.04%
==========================================
Files 215 215
Lines 52561 52410 -151
==========================================
- Hits 42935 42795 -140
+ Misses 9626 9615 -11
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9277?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/9277/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `6.97% <0.00%> (-5.13%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/empty.rs](https://codecov.io/gh/apache/arrow/pull/9277/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2VtcHR5LnJz) | `82.81% <0.00%> (-2.27%)` | :arrow_down: |
| [rust/parquet/src/file/statistics.rs](https://codecov.io/gh/apache/arrow/pull/9277/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9maWxlL3N0YXRpc3RpY3MucnM=) | `93.80% <0.00%> (-1.24%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/repartition.rs](https://codecov.io/gh/apache/arrow/pull/9277/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3JlcGFydGl0aW9uLnJz) | `73.64% <0.00%> (-0.60%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/limit.rs](https://codecov.io/gh/apache/arrow/pull/9277/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2xpbWl0LnJz) | `57.47% <0.00%> (-0.49%)` | :arrow_down: |
| [rust/arrow/src/csv/writer.rs](https://codecov.io/gh/apache/arrow/pull/9277/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY3N2L3dyaXRlci5ycw==) | `78.82% <0.00%> (-0.46%)` | :arrow_down: |
| [...tafusion/src/physical\_plan/datetime\_expressions.rs](https://codecov.io/gh/apache/arrow/pull/9277/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2RhdGV0aW1lX2V4cHJlc3Npb25zLnJz) | `92.60% <0.00%> (-0.44%)` | :arrow_down: |
| [rust/datafusion/tests/custom\_sources.rs](https://codecov.io/gh/apache/arrow/pull/9277/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3Rlc3RzL2N1c3RvbV9zb3VyY2VzLnJz) | `75.00% <0.00%> (-0.41%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/filter.rs](https://codecov.io/gh/apache/arrow/pull/9277/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2ZpbHRlci5ycw==) | `70.27% <0.00%> (-0.40%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/csv.rs](https://codecov.io/gh/apache/arrow/pull/9277/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2Nzdi5ycw==) | `74.26% <0.00%> (-0.38%)` | :arrow_down: |
| ... and [48 more](https://codecov.io/gh/apache/arrow/pull/9277/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9277?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9277?src=pr&el=footer). Last update [6912869...c636cf1](https://codecov.io/gh/apache/arrow/pull/9277?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #9277: ARROW-11329: [Rust] Don't rerun build.rs on every file change
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #9277:
URL: https://github.com/apache/arrow/pull/9277#issuecomment-763808991
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org