You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/06/11 17:32:25 UTC

[GitHub] [activemq-artemis] jbertram opened a new pull request #3178: ARTEMIS-2801 make HumanReadableByteCountTest locale sensitive

jbertram opened a new pull request #3178:
URL: https://github.com/apache/activemq-artemis/pull/3178


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3178: ARTEMIS-2801 make HumanReadableByteCountTest locale sensitive

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3178:
URL: https://github.com/apache/activemq-artemis/pull/3178#issuecomment-643028782


   Ok, I thought this was about interpreting human formats on the XML. I misunderstood it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] jbertram commented on pull request #3178: ARTEMIS-2801 make HumanReadableByteCountTest locale sensitive

Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3178:
URL: https://github.com/apache/activemq-artemis/pull/3178#issuecomment-642964397


   This really isn't about configuration. It's just about how a particular log message is formatted using `String.format`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] asfgit closed pull request #3178: ARTEMIS-2801 make HumanReadableByteCountTest locale sensitive

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3178:
URL: https://github.com/apache/activemq-artemis/pull/3178


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3178: ARTEMIS-2801 make HumanReadableByteCountTest locale sensitive

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3178:
URL: https://github.com/apache/activemq-artemis/pull/3178#issuecomment-642903589


   the broker.xml is written in English. I would keep the locale always in english on the xml.
   
   mixing it up would make it weird. eventually moving the xml from one place to another would require you to "translate" the config.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org