[jira] [Commented] (DIRKRB-113) Add tests for Kerberos message codecs

["Kiran Ayyagari (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DIRKRB-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276622#comment-14276622 ] 

Kiran Ayyagari commented on DIRKRB-113:
---------------------------------------

I see that all these tests were written based on the binary data stored in a file. we should always create the corresponding 
request/response instances using the classes we have and fill with the appropriate data in the test class itself rather than
loading the data from an external source.

This makes writing new tests near painless, see [ApReqDecoderTest|http://svn.apache.org/repos/asf/directory/apacheds/trunk/kerberos-codec/src/test/java/org/apache/directory/shared/kerberos/codec/ApReqDecoderTest.java] for example.

If writing the tests in the said manner makes it difficult at this point of time due to many moving parts then IMHO we should wait till things settle.

> Add tests for Kerberos message codecs
> -------------------------------------
>
>                 Key: DIRKRB-113
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-113
>             Project: Directory Kerberos
>          Issue Type: Sub-task
>            Reporter: Lin Chen
>            Assignee: Emmanuel Lecharny
>
> Add test cases for testing Kerberos message codecs. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)