You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by mp...@apache.org on 2016/04/10 01:18:45 UTC

[2/8] mesos git commit: Stout: Uncommented functions and marked them as `= delete` instead.

Stout: Uncommented functions and marked them as `= delete` instead.

Review: https://reviews.apache.org/r/44082/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/e5af13dc
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/e5af13dc
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/e5af13dc

Branch: refs/heads/master
Commit: e5af13dc6369a23133b388c9964671e2ead18735
Parents: 1ffa483
Author: Alex Clemmer <cl...@gmail.com>
Authored: Sat Apr 9 15:56:05 2016 -0700
Committer: Michael Park <mp...@apache.org>
Committed: Sat Apr 9 15:58:35 2016 -0700

----------------------------------------------------------------------
 .../3rdparty/stout/include/stout/windows/os.hpp | 75 +++++---------------
 1 file changed, 17 insertions(+), 58 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/e5af13dc/3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp b/3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
index e1a4557..c3f4faa 100644
--- a/3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
+++ b/3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
@@ -70,13 +70,9 @@ inline void setenv(
 }
 
 
-/*
 // Unsets the value associated with the specified key in the set of
 // environment variables.
-inline void unsetenv(const std::string& key)
-{
-  UNIMPLEMENTED;
-}
+inline void unsetenv(const std::string& key) = delete;
 
 
 // Executes a command by calling "/bin/sh -c <command>", and returns
@@ -84,10 +80,7 @@ inline void unsetenv(const std::string& key)
 // return -1 on error (e.g., fork/exec/waitpid failed). This function
 // is async signal safe. We return int instead of returning a Try
 // because Try involves 'new', which is not async signal safe.
-inline int system(const std::string& command)
-{
-  UNIMPLEMENTED;
-}
+inline int system(const std::string& command) = delete;
 
 
 // This function is a portable version of execvpe ('p' means searching
@@ -97,96 +90,62 @@ inline int system(const std::string& command)
 // NOTE: This function is not thread safe. It is supposed to be used
 // only after fork (when there is only one thread). This function is
 // async signal safe.
-inline int execvpe(const char* file, char** argv, char** envp)
-{
-  UNIMPLEMENTED;
-}
+inline int execvpe(const char* file, char** argv, char** envp) = delete;
 
 
 inline Try<Nothing> chown(
     uid_t uid,
     gid_t gid,
     const std::string& path,
-    bool recursive)
-{
-  UNIMPLEMENTED;
-}
+    bool recursive) = delete;
 
 
-inline Try<Nothing> chmod(const std::string& path, int mode)
-{
-  UNIMPLEMENTED;
-}
+inline Try<Nothing> chmod(const std::string& path, int mode) = delete;
 
 
 inline Try<Nothing> mknod(
     const std::string& path,
     mode_t mode,
-    dev_t dev)
-{
-  UNIMPLEMENTED;
-}
+    dev_t dev) = delete;
 
 
 // Suspends execution for the given duration.
-inline Try<Nothing> sleep(const Duration& duration)
-{
-  UNIMPLEMENTED;
-}
+inline Try<Nothing> sleep(const Duration& duration) = delete;
 
 
 // Returns the list of files that match the given (shell) pattern.
-inline Try<std::list<std::string>> glob(const std::string& pattern)
-{
-  UNIMPLEMENTED;
-}
+inline Try<std::list<std::string>> glob(const std::string& pattern) = delete;
 
 
 // Returns the total number of cpus (cores).
-inline Try<long> cpus()
-{
-  UNIMPLEMENTED;
-}
+inline Try<long> cpus() = delete;
 
 
 // Returns load struct with average system loads for the last
 // 1, 5 and 15 minutes respectively.
 // Load values should be interpreted as usual average loads from
 // uptime(1).
-inline Try<Load> loadavg()
-{
-  UNIMPLEMENTED;
-}
+inline Try<Load> loadavg() = delete;
 
 
 // Returns the total size of main and free memory.
-inline Try<Memory> memory()
-{
-  UNIMPLEMENTED;
-}
+inline Try<Memory> memory() = delete;
 
 
 // Return the system information.
-inline Try<UTSInfo> uname()
-{
-  UNIMPLEMENTED;
-}
+inline Try<UTSInfo> uname() = delete;
 
 
-inline Try<std::list<Process>> processes()
-{
-  UNIMPLEMENTED;
-}
+inline Try<std::list<Process>> processes() = delete;
 
 
 // Overload of os::pids for filtering by groups and sessions.
 // A group / session id of 0 will fitler on the group / session ID
 // of the calling process.
-inline Try<std::set<pid_t>> pids(Option<pid_t> group, Option<pid_t> session)
-{
-  UNIMPLEMENTED;
-}
-*/
+inline Try<std::set<pid_t>> pids(
+    Option<pid_t> group,
+    Option<pid_t> session) = delete;
+
 
 inline tm* gmtime_r(const time_t* timep, tm* result)
 {