You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/20 14:57:13 UTC

[GitHub] [superset] rosemarie-chiu opened a new issue #17170: [Explore] Chart property edit modal is cached when cancel edit

rosemarie-chiu opened a new issue #17170:
URL: https://github.com/apache/superset/issues/17170


   Only in Explore, when cancel change on chart property, it is cached. From chart list it is fine.
   
   #### How to reproduce the bug
   1. Explore and chart
   2. Edit chart property
   3. Click "Cancel" button
   4. Open chart property edit modal again
   5. See the change that was "cancelled"
   
   ### Expected results
   If I cancelled changes, it should be cancelled and not show on UI. 
   
   ### Actual results
   Edit modal shows what I have cancelled, it is confusing
   
   
   #### Screenshots
   
   ![CleanShot 2021-10-20 at 22 51 04](https://user-images.githubusercontent.com/52086618/138117043-2aa16d35-16f9-4d9e-8101-ca8e32afa108.gif)
   
   
   ### Environment
   
   (please complete the following information):
   
   - browser type and version: Chrome latest
   - superset version: latest master
   - any feature flags active: default feature flags combo
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido closed issue #17170: [Explore] Chart property edit modal is cached when cancel edit

Posted by GitBox <gi...@apache.org>.
geido closed issue #17170:
URL: https://github.com/apache/superset/issues/17170


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido closed issue #17170: [Explore] Chart property edit modal is cached when cancel edit

Posted by GitBox <gi...@apache.org>.
geido closed issue #17170:
URL: https://github.com/apache/superset/issues/17170


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido closed issue #17170: [Explore] Chart property edit modal is cached when cancel edit

Posted by GitBox <gi...@apache.org>.
geido closed issue #17170:
URL: https://github.com/apache/superset/issues/17170


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org