You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "hiirrxnn (via GitHub)" <gi...@apache.org> on 2024/01/09 13:07:23 UTC
[PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
hiirrxnn opened a new pull request, #160:
URL: https://github.com/apache/iceberg-rust/pull/160
Also includes new changes requested by collaborators ! Let me know if there are changes to be made !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1886079899
cc @Fokko PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "hiirrxnn (via GitHub)" <gi...@apache.org>.
hiirrxnn commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1886724423
Should i rebase feature (the branch whose PR this is) with main? Or should i merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1883160875
@hiirrxnn oops, I just merged another PR, and now have merge conflicts 🤦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1886115997
Looks like there are conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "hiirrxnn (via GitHub)" <gi...@apache.org>.
hiirrxnn commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1886231297
Also , feature anyway has all the changes of main since it has been built on top of it , or should i rebase main with feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "hiirrxnn (via GitHub)" <gi...@apache.org>.
hiirrxnn commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1889638975
Please review !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1890339709
Thanks @hiirrxnn for working on this 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1886741367
> Should i rebase feature (the branch whose PR this is) with main? Or should i merge?
I think both are ok to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1888371442
Hi, @hiirrxnn The `cargo sort` check failed, you can run `cargo sort -w` to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "hiirrxnn (via GitHub)" <gi...@apache.org>.
hiirrxnn commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1886827154
Please review .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#discussion_r1446788153
##########
crates/test_utils/Cargo.toml:
##########
@@ -17,8 +17,9 @@
[package]
name = "iceberg_test_utils"
-version = "0.1.0"
-edition = "2021"
+version = {workspace = true}
+edition = {workspace = true}
+homepage = {workspace = true}
Review Comment:
I think we also need repository and license for this crate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "hiirrxnn (via GitHub)" <gi...@apache.org>.
hiirrxnn commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1886208226
But the PR with main branch has been closed . Should i do it anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1886155116
cc @hiirrxnn Could you rebase with main branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "hiirrxnn (via GitHub)" <gi...@apache.org>.
hiirrxnn commented on code in PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#discussion_r1446793818
##########
crates/test_utils/Cargo.toml:
##########
@@ -17,8 +17,9 @@
[package]
name = "iceberg_test_utils"
-version = "0.1.0"
-edition = "2021"
+version = {workspace = true}
+edition = {workspace = true}
+homepage = {workspace = true}
Review Comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "hiirrxnn (via GitHub)" <gi...@apache.org>.
hiirrxnn commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1890340610
I'm glad to have collaborated with you guys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1886347244
> Also , feature anyway has all the changes of main since it has been built on top of it , or should i rebase main with feature?
Hi, @hiirrxnn You can learn how to resolve conflicts here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "hiirrxnn (via GitHub)" <gi...@apache.org>.
hiirrxnn commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1883185925
Is there something that needs to be done from my side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1884048411
@hiirrxnn Thanks for the contribution!
A small tip: you can run `make check` to verify things like formatting, linting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] #154 : Add homepage to Cargo.toml [iceberg-rust]
Posted by "hiirrxnn (via GitHub)" <gi...@apache.org>.
hiirrxnn commented on PR #160:
URL: https://github.com/apache/iceberg-rust/pull/160#issuecomment-1884052968
Noted ! I'm new to github , will definitely keep this in mind for the future . I have closed previous PR as you suggested !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org