You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Ron Gavlin (JIRA)" <ji...@apache.org> on 2009/02/22 14:18:59 UTC
[jira] Updated: (SMXCOMP-461) Fix smx-cxf-bc consumer timeout
property JavaDoc and code interpretation
[ https://issues.apache.org/activemq/browse/SMXCOMP-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ron Gavlin updated SMXCOMP-461:
-------------------------------
Patch Info: (was: [Patch Available])
Description:
The current JavaDoc for the timeout property is below.
/**
* Specifies the interval for which the endpoint will wait for a
* response, This is specified in seconds.
*
* @param timeout the number of millis to wait for a response
* @org.apache.xbean.Property description="the number of millis the endpoint will wait for a response. The default is 1 hour."
**/
public void setTimeout(long timeout) {
this.timeout = timeout;
}
Here, some of the documentation states the timeout unit is seconds and the other part states it is milliseconds. It also states the default timeout is 1 hour when it is really 0 (unlimited).
Furthermore, after reviewing the CxfBcConsumer.java code, it appears the code may be inconsistent as well. The deliveryChannel.sendSync(timeout) uses the timeout property as is (indicating it expects the unit of measure to be milliseconds). However, the CXF continuation.suspend(timeout * 1000) indicates it expects the unit of measure to be seconds.
This inconsistency should be resolved ASAP.
was:
The current JavaDoc for the timeout property is below.
/**
* Specifies the interval for which the endpoint will wait for a
* response, This is specified in seconds.
*
* @param timeout the number of millis to wait for a response
* @org.apache.xbean.Property description="the number of millis the endpoint will wait for a response. The default is 1 hour."
**/
public void setTimeout(long timeout) {
this.timeout = timeout;
}
The corrected JavaDoc follows:
/**
* Specifies the interval for which the endpoint will wait for a
* response, This is specified in seconds.
*
* @param timeout the number of seconds to wait for a response
* @org.apache.xbean.Property description="the number of seconds the endpoint will wait for a response. The default is 0 (unlimited)."
**/
public void setTimeout(long timeout) {
this.timeout = timeout;
}
Summary: Fix smx-cxf-bc consumer timeout property JavaDoc and code interpretation (was: Fix the JavaDoc for the smx-cxf-bc consumer timeout property )
> Fix smx-cxf-bc consumer timeout property JavaDoc and code interpretation
> ------------------------------------------------------------------------
>
> Key: SMXCOMP-461
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-461
> Project: ServiceMix Components
> Issue Type: Bug
> Affects Versions: servicemix-cxf-bc-2008.01
> Reporter: Ron Gavlin
>
> The current JavaDoc for the timeout property is below.
> /**
> * Specifies the interval for which the endpoint will wait for a
> * response, This is specified in seconds.
> *
> * @param timeout the number of millis to wait for a response
> * @org.apache.xbean.Property description="the number of millis the endpoint will wait for a response. The default is 1 hour."
> **/
> public void setTimeout(long timeout) {
> this.timeout = timeout;
> }
> Here, some of the documentation states the timeout unit is seconds and the other part states it is milliseconds. It also states the default timeout is 1 hour when it is really 0 (unlimited).
> Furthermore, after reviewing the CxfBcConsumer.java code, it appears the code may be inconsistent as well. The deliveryChannel.sendSync(timeout) uses the timeout property as is (indicating it expects the unit of measure to be milliseconds). However, the CXF continuation.suspend(timeout * 1000) indicates it expects the unit of measure to be seconds.
> This inconsistency should be resolved ASAP.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.