You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/15 15:33:15 UTC

[GitHub] [flink] dawidwys commented on a change in pull request #13647: [FLINK-19640] Enable sorting inputs for batch

dawidwys commented on a change in pull request #13647:
URL: https://github.com/apache/flink/pull/13647#discussion_r505639934



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamNode.java
##########
@@ -336,15 +341,30 @@ public void setUserHash(String userHash) {
 		this.userHash = userHash;
 	}
 
-	@VisibleForTesting
 	public void setSortedInputs(boolean sortedInputs) {
 		this.sortedInputs = sortedInputs;
 	}
 
-	boolean getSortedInputs() {
+	public boolean getSortedInputs() {
 		return sortedInputs;
 	}
 
+	public void setStateBackend(StateBackend stateBackend) {

Review comment:
       After offline sync and some more thinking and I thought it is actually dangerous to set the state backend on a per node level. I will revert back to setting state backend only on the StreamGraph level and throw an exception if there is an InputSelectable operator for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org