You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2008/11/26 08:19:06 UTC

[jira] Created: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: SMX4KNL-152
                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
             Project: ServiceMix Kernel
          Issue Type: New Feature
            Reporter: Guillaume Nodet
             Fix For: 1.1.0




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=49108#action_49108 ] 

Guillaume Nodet commented on SMX4KNL-152:
-----------------------------------------

Edell, would you mind committing the required changes to the features project and close this issue ?

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, SMX-4-152.patch, SMX4KNL-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment:     (was: kernel-smx152.patch)

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48769#action_48769 ] 

Edell Nolan commented on SMX4KNL-152:
-------------------------------------

Right - there should be no problems applying these patches to the kernel and features.  Sorry about the inconvience of the previous patches.

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, SMX-4-152.patch, SMX4KNL-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment: branding-152.zip

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding-152.zip, new-smx-knl-152.patch, smx4-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48469#action_48469 ] 

Guillaume Nodet commented on SMX4KNL-152:
-----------------------------------------

Yes, it sounds reasonable.
Maybe a slightly better way to avoid changing the startup.properties would be to automatically mark the package as exported by the system bundle (in config.properties).  It should work even if the package is not present.  When embedding smx kernel, it would required putting a jar in the lib folder instead of the system folder, and it should be added to the classpath automatically, thus making it available for all other bundles.

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment:     (was: branding.zip)

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48467#action_48467 ] 

Edell Nolan commented on SMX4KNL-152:
-------------------------------------

Hi Guillaume,

I have got this working as regards the following

I import a package org/apache/ser vicemix/kernel/version that contains an embedded.properties file that defines the embedding applications name, version and banner.

If this file doesn't exist then the kernel defaults are used which means it is not embedded.

If the file does exist which it will in the "Servicemix 4" distribution within a branding bundle. It will then output something like the following

 ____                  _          __  __ _
/ ___|  ___ _ ____   _(_) ___ ___|  \/  (_)_  __
\___ \ / _ \ '__\ \ / / |/ __/ _ \ |\/| | \ \/ /
 ___) |  __/ |   \ V /| | (_|  __/ |  | | |>  <
|____/ \___|_|    \_/ |_|\___\___|_|  |_|_/_/\_\

 ServiceMix Kernel (1.1.0)
 ServiceMix (4.1.0-fuse-SNAPSHOT)

Type 'help' for more information.


About command
=================
servicemix kernel
1.1.0

ServiceMix 4.1.0-fuse-SNAPSHOT

For information about ServiceMix Kernel, visit:
    http://servicemix.apache.org

Info command 
===============
ServiceMix
  ServiceMix home             C:\fuse-kernel-kit4
  ServiceMix base             C:\fuse-kernel-kit4
  ServiceMix kernel version   1.1.0
  ServiceMix version          4.1.0-fuse-SNAPSHOT
  .........

The only requirement is that the startup.properties needs to be modified to install the branding bundle before the console starts.
But we should be able to append a line from within the servicemix assembly to this file.

Does this approach seem reasonable ?

thanks, Edell.



> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment:     (was: servicemix-version.jar)

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=49114#action_49114 ] 

Edell Nolan commented on SMX4KNL-152:
-------------------------------------

Yes will do this today.

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, SMX-4-152.patch, SMX4KNL-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment: branding.zip

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, config.properties, kernel-smx152.patch, servicemix-version.jar
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48266#action_48266 ] 

Guillaume Nodet commented on SMX4KNL-152:
-----------------------------------------

I'm mostly thinking that changing the banners is not something that end users would do.
It's more targeted towards people embedding smx kernel to build their own container, just like we do in the full servicemix 4 distribution.
So using a jar does not seem like a problem to me, quite the opposite (so that end users won't change it easily).

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Assignee: Edell Nolan

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48609#action_48609 ] 

Guillaume Nodet commented on SMX4KNL-152:
-----------------------------------------

I can not apply the patch on trunk.
Anyway, if the resource can't be loaded, it might be caused because the wrong classloader is used.  You should not use
{code}
this.bundleContext.getBundle().getClass().getClassLoader().getResource(EMBEDDED_PROPS)
{code} 
but try with 
{code}
this.getClass().getClassLoader().getResource(EMBEDDED_PROPS)
{code}


> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, config.properties, kernel-smx152.patch, servicemix-version.jar
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48646#action_48646 ] 

Edell Nolan commented on SMX4KNL-152:
-------------------------------------

Hi Guillaume,

I have finally got this to work and I have tested it in both a Kernel kit (trunk) and a Servicemix 4 kit built off trunk.
The extra info is output in the Servicemix 4 kit. 

I have attached the two patches and a zip that includes a branding directory - this just needs to be added into the top-level directory of Servicemix trunk as tortoise won't allow be to create a patch with new files within it. 

thanks, Edell.

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding-152.zip, new-smx-knl-152.patch, smx4-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48224#action_48224 ] 

Guillaume Nodet commented on SMX4KNL-152:
-----------------------------------------

So the goal is to be able to display informations about the application using an embedded ServiceMix Kernel.
The first obvious example is the full Smx4 distribution, which has a different version.
I guess the kernel should display its own version along with the version of the embedding application.
So there are two places that are affected: the banner displayed when the console is started and the Info command.
I'm not sure that using a properties file from the kit is the way to go, i would rather try to use a file embedded in a jar
instead, as such informations are not supposed to be changed by the end user.

So we need to define somewhere a location that will be looked by the kernel to load the attributes of the branding.
In the InfoAction class, we need to display both the kernel version and the application version if it has been defined.
Note that currently, the kernel version is hardcoded in the gshell.xml spring config file and should be retrieved 
from the servicemix-version.properties file instead ...

Remember that in OSGi, access to resources is limited by the way the classloader is set up, so it might make sense
to first try with a plain property file in a known location like ${servicemix.home}/etc, and then figure out if we can use
resources for that.

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment:     (was: branding-152.zip)

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment:     (was: smx4-152.patch)

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48877#action_48877 ] 

Guillaume Nodet commented on SMX4KNL-152:
-----------------------------------------

Patch on smx kernel applied (with small modifications to load the version number from resources instead of hard-coded in the spring app).

Sending        etc/config.properties
Sending        gshell/gshell-core/pom.xml
Sending        gshell/gshell-core/src/main/java/org/apache/servicemix/kernel/gshell/core/ApplicationImpl.java
Sending        gshell/gshell-core/src/main/java/org/apache/servicemix/kernel/gshell/core/ServiceMixBranding.java
Sending        gshell/gshell-core/src/main/java/org/apache/servicemix/kernel/gshell/core/commands/InfoAction.java
Sending        gshell/gshell-core/src/main/resources/META-INF/spring/gshell.xml
Sending        gshell/gshell-core/src/test/java/org/apache/servicemix/kernel/gshell/core/Test.java
Transmitting file data .......
Committed revision 736272.

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, SMX-4-152.patch, SMX4KNL-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment: smx4-152.patch

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding-152.zip, new-smx-knl-152.patch, smx4-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48225#action_48225 ] 

Edell Nolan commented on SMX4KNL-152:
-------------------------------------

I have set it up on a properties file in servicemix.home/etc and that seems to be working.
But I was trying to track down where the id and version were coming from when you execute the About command
I tried extending the AboutAction class but the thing is that the Branding class doesn't have a version op but I guess we can try and define spring to pick that up from the servicemix-version.properties file. 

If we put the banner in a file inside a jar does this not prevent people from changing it ? 

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan resolved SMX4KNL-152.
---------------------------------

    Resolution: Fixed

Patches committed to both kernel and features.

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, SMX-4-152.patch, SMX4KNL-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48288#action_48288 ] 

Edell Nolan commented on SMX4KNL-152:
-------------------------------------

After some discussion with Guillaume on irc - I am going to look into an approach where we can import an optional package in the gshell core that includes a resource with the embedding applications details. If the resource is not there we assume the kernel is not embedded in any other application so the default settings will be used. 



> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment: kernel-smx152.patch

Src changes for the kernel

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, config.properties, kernel-smx152.patch, servicemix-version.jar
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work stopped: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on SMX4KNL-152 stopped by Edell Nolan.

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, SMX-4-152.patch, SMX4KNL-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=49119#action_49119 ] 

Edell Nolan commented on SMX4KNL-152:
-------------------------------------

Committed patches for features.

http://svn.apache.org/viewvc?view=rev&revision=740776



> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, SMX-4-152.patch, SMX4KNL-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Description: 
Hi Guillaume,

I have done some initial work around this but wanted to check that I am on the right track.

Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?

thanks, Edell.



> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48592#action_48592 ] 

Edell Nolan commented on SMX4KNL-152:
-------------------------------------

Hi Guillaume,

I attached the test patch - my src changes for the kernel are in kernel-smx152.patch
I search for the embedded.properties in the org.apache.servicemix.kernel.gshell.core.ApplicationImpl.java 

With embbedding the kernel in serivcemix - I attached the new code in the branding.zip (So this code will go into the features project) and the servicemix-version.jar is just a built version of this that I was testing with in the lib directory of the kit.

The Attached config.properties is the one I was using in the kit.

cheers, Edell.

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, config.properties, kernel-smx152.patch, servicemix-version.jar
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48766#action_48766 ] 

Edell Nolan commented on SMX4KNL-152:
-------------------------------------

I have figured out why you can't apply the patches - bug on my part - fixing this currently.

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding-152.zip, new-smx-knl-152.patch, smx4-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment: SMX-4-152.patch

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, SMX-4-152.patch, SMX4KNL-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment: new-smx-knl-152.patch

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding-152.zip, new-smx-knl-152.patch, smx4-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment: config.properties

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, config.properties, kernel-smx152.patch, servicemix-version.jar
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment:     (was: config.properties)

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment: servicemix-version.jar

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, config.properties, kernel-smx152.patch, servicemix-version.jar
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work started: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on SMX4KNL-152 started by Edell Nolan.

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment: SMX4KNL-152.patch

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, SMX-4-152.patch, SMX4KNL-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment:     (was: new-smx-knl-152.patch)

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edell Nolan updated SMX4KNL-152:
--------------------------------

    Attachment: branding.zip

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>         Attachments: branding.zip, SMX-4-152.patch, SMX4KNL-152.patch
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.