You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by pd...@apache.org on 2025/06/10 06:36:16 UTC
(zeppelin) branch branch-0.12 updated: [ZEPPELIN-6185] fix prevent shortcut working in input field
This is an automated email from the ASF dual-hosted git repository.
pdallig pushed a commit to branch branch-0.12
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/branch-0.12 by this push:
new b3c89085a7 [ZEPPELIN-6185] fix prevent shortcut working in input field
b3c89085a7 is described below
commit b3c89085a7bec30eb33429b9d45e771799d93d4e
Author: Soonoh <so...@gmail.com>
AuthorDate: Tue Jun 10 15:35:37 2025 +0900
[ZEPPELIN-6185] fix prevent shortcut working in input field
### What is this PR for?
This PR fixes an issue that prevents entering shortcut characters in input fields.
When using a dynamic input field, characters like 'l', 'b', etc., are treated as shortcuts and cannot be entered.
This fix prevents shortcut actions from being triggered when the focused element is an input field.
### What type of PR is it?
Bug Fix
### Todos
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-6185
### How should this be tested?
* Create new notebook using dynamic input field
* Enter 'l' character and see if it is not working as shortcut(toggling line numbers)
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Closes #4925 from sh1nj1/fix/shortcut-in-text-field.
Signed-off-by: Philipp Dallig <ph...@gmail.com>
(cherry picked from commit 94ae845cd4a7fd6058e936d82f817e1ef8618a64)
Signed-off-by: Philipp Dallig <ph...@gmail.com>
---
.../app/pages/workspace/notebook/paragraph/paragraph.component.ts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/paragraph.component.ts b/zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/paragraph.component.ts
index 719877ad00..33da303291 100644
--- a/zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/paragraph.component.ts
+++ b/zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/paragraph.component.ts
@@ -466,6 +466,13 @@ export class NotebookParagraphComponent extends ParagraphBase implements OnInit,
}>(...observables)
.pipe(takeUntil(this.destroy$))
.subscribe(({ action, event }) => {
+ const target = event.target as HTMLElement;
+
+ // Skip handling shortcut if focused element is an input (by Dynamic form)
+ if (target.tagName === 'INPUT') {
+ return; // ignore shortcut to make input work
+ }
+
if (this.mode === 'command') {
switch (action) {
case ParagraphActions.InsertAbove: