You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/03/09 19:15:42 UTC

[kudu-CR] [tablet] output more info for long row lock waits

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18300


Change subject: [tablet] output more info for long row lock waits
......................................................................

[tablet] output more info for long row lock waits

While troubleshooting one performance issue, I found that the messages
on long-wait row locks didn't provide a lot of useful information
especially when log redaction was on (it's on by default).

This patch address that, so now it's easier to tell:
  * what's the tablet where the congestion happens
  * whether recurrent messages are about the same primary key
    as for prior messages

Before:
  Waited 2 seconds to obtain row lock on key <redacted> cur holder: 0x2f2e85180

After:
  Waited 2 seconds to obtain row lock on key '<redacted>' (key hash 8560710080558783806) tablet 18b47e40a6864ff39d1d82accf7202ec cur holder 0x2f2e85180

Change-Id: I521976ff6986676ad9a33a810c56eaa8e7deeab8
---
M src/kudu/tablet/lock_manager.cc
M src/kudu/tablet/tablet_replica-test.cc
2 files changed, 71 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/18300/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I521976ff6986676ad9a33a810c56eaa8e7deeab8
Gerrit-Change-Number: 18300
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [tablet] output more info for long row lock waits

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18300 )

Change subject: [tablet] output more info for long row lock waits
......................................................................

[tablet] output more info for long row lock waits

While troubleshooting one performance issue, I found that the messages
on long-wait row locks didn't provide a lot of useful information
especially when log redaction was on (it's on by default).

This patch address that, so now it's easier to tell:
  * what's the tablet where the congestion happens
  * whether recurrent messages are about the same primary key
    as for prior messages

Before:
  Waited 2 seconds to obtain row lock on key <redacted> cur holder: 0x2f2e85180

After:
  Waited 2 seconds to obtain row lock on key '<redacted>' (key hash 8560710080558783806) tablet 18b47e40a6864ff39d1d82accf7202ec cur holder 0x2f2e85180

Change-Id: I521976ff6986676ad9a33a810c56eaa8e7deeab8
Reviewed-on: http://gerrit.cloudera.org:8080/18300
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/tablet/lock_manager.cc
M src/kudu/tablet/tablet_replica-test.cc
2 files changed, 71 insertions(+), 5 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I521976ff6986676ad9a33a810c56eaa8e7deeab8
Gerrit-Change-Number: 18300
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tablet] output more info for long row lock waits

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18300 )

Change subject: [tablet] output more info for long row lock waits
......................................................................


Patch Set 1: Code-Review+2

Thanks for addressing this!


-- 
To view, visit http://gerrit.cloudera.org:8080/18300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I521976ff6986676ad9a33a810c56eaa8e7deeab8
Gerrit-Change-Number: 18300
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 09 Mar 2022 20:48:02 +0000
Gerrit-HasComments: No