You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/09/19 02:03:06 UTC
[GitHub] [incubator-mxnet] rongzha1 commented on a change in pull request
#16199: [mkldnn-v1.0] Add MKL-DNN BN
rongzha1 commented on a change in pull request #16199: [mkldnn-v1.0] Add MKL-DNN BN
URL: https://github.com/apache/incubator-mxnet/pull/16199#discussion_r325962503
##########
File path: src/operator/nn/mkldnn/mkldnn_batch_norm-inl.h
##########
@@ -185,21 +119,20 @@ class MKLDNNBNForward {
template<typename DType>
static MKLDNNBNForward &GetBNForward(const BatchNormParam& param,
const OpContext &ctx, const mkldnn::memory *data_mem,
- unsigned flags) {
+ mkldnn::normalization_flags flags) {
#if DMLC_CXX11_THREAD_LOCAL
static thread_local std::unordered_map<MKLDNNBNSignature, MKLDNNBNForward, OpHash> fwds;
#else
static MX_THREAD_LOCAL std::unordered_map<MKLDNNBNSignature, MKLDNNBNForward, OpHash> fwds;
#endif
MKLDNNBNSignature key(param);
key.AddSign(ctx.is_train);
- key.AddSign(param.use_global_stats);
Review comment:
MKLDNNBNSignature key(param) will hash param structure which include param.use_global_stats
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services