You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficserver.apache.org by masaori335 <gi...@git.apache.org> on 2016/08/01 03:14:54 UTC

[GitHub] trafficserver pull request #833: TS-3474: HTTP/2 Server Push support

Github user masaori335 commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/833#discussion_r72919885
  
    --- Diff: proxy/http2/Http2ConnectionState.cc ---
    @@ -41,7 +41,7 @@ static const int buffer_size_index[HTTP2_FRAME_TYPE_MAX] = {
       -1,                    // HTTP2_FRAME_TYPE_PRIORITY
       BUFFER_SIZE_INDEX_128, // HTTP2_FRAME_TYPE_RST_STREAM
       BUFFER_SIZE_INDEX_128, // HTTP2_FRAME_TYPE_SETTINGS
    -  -1,                    // HTTP2_FRAME_TYPE_PUSH_PROMISE
    +  BUFFER_SIZE_INDEX_128, // HTTP2_FRAME_TYPE_PUSH_PROMISE
    --- End diff --
    
    `128` is enough size for PUSH_PROMISE frame? It contains Header Block Fragment, so 16K (like HEADERS frame and CONTINUATION frame) is appropriate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---