You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by "Remko Popma (JIRA)" <ji...@apache.org> on 2015/10/01 00:05:04 UTC

[jira] [Commented] (LOG4J2-1142) ThreadLocals in Layout implementations should be non-static to prevent memory leaks in web containers

    [ https://issues.apache.org/jira/browse/LOG4J2-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938952#comment-14938952 ] 

Remko Popma commented on LOG4J2-1142:
-------------------------------------

Gary, {{ThreadLocal.remove()}} only removes the value for the current (calling) thread, so only one of the values would be removed.

> ThreadLocals in Layout implementations should be non-static to prevent memory leaks in web containers
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LOG4J2-1142
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1142
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Layouts
>    Affects Versions: 2.4
>            Reporter: Dmitri Blinov
>            Assignee: Remko Popma
>             Fix For: 2.4.1
>
>
> As discussed in LOG4J2-1125, storing ThreadLocal<StringBuilder> in a static field may not interact well with the thread pools and class loaders of some web containers and may result in memory leaks, especially in older web containers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org