You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/09 16:53:35 UTC

[GitHub] [airflow] zachliu edited a comment on issue #22063: Status of testing Providers that were prepared on March 07, 2022

zachliu edited a comment on issue #22063:
URL: https://github.com/apache/airflow/issues/22063#issuecomment-1063112695


   i tested https://github.com/apache/airflow/pull/22002. good news: the retry did kick in :rocket: 
   ~however, i'd like to add `reraise: True` in the `default_kwargs` here~
   https://github.com/apache/airflow/blob/a4d514bd7f7777e5bf03e9fa8e567f1c8774a74d/airflow/providers/amazon/aws/hooks/base_aws.py#L588-L594
   
   ~otherwise we get a very vague exception when we exhaust all retries~
   ```
   tenacity.RetryError: RetryError[<Future at 0x7f143d69a9a0 state=finished raised Exception>]
   ```
   
   i changed my mind, keeping `reraise=False` by default is fine :sweat_smile: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org