You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/27 15:00:05 UTC
[GitHub] [spark] cloud-fan opened a new pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
cloud-fan opened a new pull request #34403:
URL: https://github.com/apache/spark/pull/34403
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR adds a new config to optionally enforce the ANSI reserved keywords in the parser. The default value is true, so we by default still enforce it and there is no behavior change.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In Spark 3.2, the ANSI mode is GA. We want more people to try and use the ANSI mode, to find data issues as early as possible and get better data quality. However, the reserved keywords thing is a big stopper for many users that want to try ANSI mode. They have to update the SQL queries to pass the parser, which is nothing about data quality and just trouble.
With a new config to allow users to not enforce reserved keywords, I think we can get better adoption of the ANSI mode.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
updated tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #34403:
URL: https://github.com/apache/spark/pull/34403#discussion_r737589537
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
##########
@@ -933,10 +933,18 @@ class ExpressionParserSuite extends AnalysisTest {
assertEqual("current_timestamp", CurrentTimestamp())
}
- withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
+ def testNonAnsiBehavior(): Unit = {
assertEqual("current_date", UnresolvedAttribute.quoted("current_date"))
assertEqual("current_timestamp", UnresolvedAttribute.quoted("current_timestamp"))
}
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
Review comment:
nit: let's explicit have `SQLConf.ENFORCE_RESERVED_KEYWORDS.key -> "true"` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a change in pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on a change in pull request #34403:
URL: https://github.com/apache/spark/pull/34403#discussion_r737650262
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1728,7 +1728,7 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logg
}
override def visitCurrentLike(ctx: CurrentLikeContext): Expression = withOrigin(ctx) {
- if (conf.ansiEnabled) {
+ if (conf.ansiEnabled && conf.enforceReservedKeywords) {
Review comment:
We only need `conf.enforceReservedKeywords` since it implies ANSI is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953018436
@gengliangwang @maropu @dongjoon-hyun @allisonwang-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953274444
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144663/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953109284
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49132/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953349424
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144667/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953232146
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49136/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953131691
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49132/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953072442
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49132/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #34403:
URL: https://github.com/apache/spark/pull/34403#discussion_r737589537
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
##########
@@ -933,10 +933,18 @@ class ExpressionParserSuite extends AnalysisTest {
assertEqual("current_timestamp", CurrentTimestamp())
}
- withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
+ def testNonAnsiBehavior(): Unit = {
assertEqual("current_date", UnresolvedAttribute.quoted("current_date"))
assertEqual("current_timestamp", UnresolvedAttribute.quoted("current_timestamp"))
}
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
Review comment:
nit: let's explicitly have `SQLConf.ENFORCE_RESERVED_KEYWORDS.key -> "true"` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953132646
**[Test build #144667 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144667/testReport)** for PR 34403 at commit [`9e6188c`](https://github.com/apache/spark/commit/9e6188c45e4d86da4a5ce296fd7df03f26c5c077).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953185331
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49136/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953132646
**[Test build #144667 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144667/testReport)** for PR 34403 at commit [`9e6188c`](https://github.com/apache/spark/commit/9e6188c45e4d86da4a5ce296fd7df03f26c5c077).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34403:
URL: https://github.com/apache/spark/pull/34403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34403:
URL: https://github.com/apache/spark/pull/34403#discussion_r737654641
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
##########
@@ -933,10 +933,18 @@ class ExpressionParserSuite extends AnalysisTest {
assertEqual("current_timestamp", CurrentTimestamp())
}
- withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
+ def testNonAnsiBehavior(): Unit = {
assertEqual("current_date", UnresolvedAttribute.quoted("current_date"))
assertEqual("current_timestamp", UnresolvedAttribute.quoted("current_timestamp"))
}
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
Review comment:
oh you want to test this behavior? makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953272870
**[Test build #144663 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144663/testReport)** for PR 34403 at commit [`7539217`](https://github.com/apache/spark/commit/75392175f67086ff4f0408880626f2e3b814ac32).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34403:
URL: https://github.com/apache/spark/pull/34403#discussion_r737654288
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
##########
@@ -933,10 +933,18 @@ class ExpressionParserSuite extends AnalysisTest {
assertEqual("current_timestamp", CurrentTimestamp())
}
- withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
+ def testNonAnsiBehavior(): Unit = {
assertEqual("current_date", UnresolvedAttribute.quoted("current_date"))
assertEqual("current_timestamp", UnresolvedAttribute.quoted("current_timestamp"))
}
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
Review comment:
As documented, `ENFORCE_RESERVED_KEYWORDS` is only effective when ansi mode is on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953232188
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49136/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953232188
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49136/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953027062
**[Test build #144663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144663/testReport)** for PR 34403 at commit [`7539217`](https://github.com/apache/spark/commit/75392175f67086ff4f0408880626f2e3b814ac32).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953348231
**[Test build #144667 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144667/testReport)** for PR 34403 at commit [`9e6188c`](https://github.com/apache/spark/commit/9e6188c45e4d86da4a5ce296fd7df03f26c5c077).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953349424
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144667/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953027062
**[Test build #144663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144663/testReport)** for PR 34403 at commit [`7539217`](https://github.com/apache/spark/commit/75392175f67086ff4f0408880626f2e3b814ac32).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953131691
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49132/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953274444
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144663/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34403:
URL: https://github.com/apache/spark/pull/34403#issuecomment-953502621
the last commit just updates the doc. I'm merging it to master, thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org