You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2024/07/27 19:47:16 UTC
[PR] Fix broken/renamed internal API method [airflow]
jscheffl opened a new pull request, #41070:
URL: https://github.com/apache/airflow/pull/41070
While rebasing I realized that one mapped method in internal API was renamed and broke the internal API.
This PR fixes back to the correct name.
@potiuk How could this happen if internal API is used in CI tests? I thought this is enabled now? Do we need another safety-net?
To prevent regression I added a pytest to check that method-map can be built, means this will fail if any method is moving-away
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix broken/renamed internal API method [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #41070:
URL: https://github.com/apache/airflow/pull/41070#issuecomment-2254239334
> And yeah. By implementing the test you already implemented [This one](https://github.com/apache/airflow/issues/28695)
I would say the pytest is 50% of it. Still you could add the decorator and miss listing the method in the method-map. Then the test will not fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix broken/renamed internal API method [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #41070:
URL: https://github.com/apache/airflow/pull/41070#issuecomment-2254240106
Agreed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix broken/renamed internal API method [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #41070:
URL: https://github.com/apache/airflow/pull/41070#issuecomment-2254238500
Yeah. I also found it and fixed in https://github.com/apache/airflow/pull/41067 - so yeah. That's exactly what will not happen when we run the tests :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix broken/renamed internal API method [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #41070:
URL: https://github.com/apache/airflow/pull/41070#issuecomment-2254238793
And yeah. By implementing the test you already implemented [the](https://github.com/apache/airflow/issues/28695)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix broken/renamed internal API method [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #41070:
URL: https://github.com/apache/airflow/pull/41070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org