You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/06/12 15:49:45 UTC
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/
-----------------------------------------------------------
(Updated June 12, 2017, 3:49 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Updated the 'depends on field' so the chain gets pulled in correctly.
Bugs: MESOS-7283
https://issues.apache.org/jira/browse/MESOS-7283
Repository: mesos
Description
-------
This infrastructure includes the ability to bring up a test cluster to
run the CLI against. Future unit tests will use this infrastructure to
test their commands against a running mesos cluster. The tests require
some binaries created when building Mesos.
Diffs
-----
src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
src/cli_new/lib/cli/tests/base.py PRE-CREATION
src/cli_new/lib/cli/tests/constants.py PRE-CREATION
src/cli_new/lib/cli/tests/tests.py PRE-CREATION
src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
Diff: https://reviews.apache.org/r/58720/diff/16/
Testing
-------
PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
$ cd src/cli_new
$ ./bootstrap
$ source activate
(mesos-cli) $ mesos-cli-tests
Thanks,
Armand Grillet
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review177631
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On June 12, 2017, 3:49 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
>
> (Updated June 12, 2017, 3:49 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
> src/cli_new/lib/cli/tests/base.py PRE-CREATION
> src/cli_new/lib/cli/tests/constants.py PRE-CREATION
> src/cli_new/lib/cli/tests/tests.py PRE-CREATION
> src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
> src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
>
>
> Diff: https://reviews.apache.org/r/58720/diff/16/
>
>
> Testing
> -------
>
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
>
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
>
> (mesos-cli) $ mesos-cli-tests
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review177630
-----------------------------------------------------------
src/cli_new/lib/cli/tests/base.py
Lines 216 (patched)
<https://reviews.apache.org/r/58720/#comment251324>
I had to change this line as:
```
diff --git a/src/cli_new/lib/cli/tests/base.py b/src/cli_new/lib/cli/tests/base.py
index 94cbb0879..62a4ee8ac 100644
--- a/src/cli_new/lib/cli/tests/base.py
+++ b/src/cli_new/lib/cli/tests/base.py
@@ -213,7 +213,7 @@ class Agent(Executable):
if "runtime_dir" not in flags:
flags["runtime_dir"] = tempfile.mkdtemp()
# Disabling systemd support on Linux to run without sudo.
- if sys.platform == "linux" and "systemd_enable_support" not in flags:
+ if "linux" in sys.platform and "systemd_enable_support" not in flags:
flags["systemd_enable_support"] = "false"
self.flags = flags
```
I will simply commit this witht his change in leiu of doing another round of reviews.
Thanks for beig so patient!
- Kevin Klues
On June 12, 2017, 3:49 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
>
> (Updated June 12, 2017, 3:49 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
> src/cli_new/lib/cli/tests/base.py PRE-CREATION
> src/cli_new/lib/cli/tests/constants.py PRE-CREATION
> src/cli_new/lib/cli/tests/tests.py PRE-CREATION
> src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
> src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
>
>
> Diff: https://reviews.apache.org/r/58720/diff/16/
>
>
> Testing
> -------
>
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
>
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
>
> (mesos-cli) $ mesos-cli-tests
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review177634
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59634, 58720]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On June 12, 2017, 8:49 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
>
> (Updated June 12, 2017, 8:49 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
> src/cli_new/lib/cli/tests/base.py PRE-CREATION
> src/cli_new/lib/cli/tests/constants.py PRE-CREATION
> src/cli_new/lib/cli/tests/tests.py PRE-CREATION
> src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
> src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
>
>
> Diff: https://reviews.apache.org/r/58720/diff/16/
>
>
> Testing
> -------
>
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
>
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
>
> (mesos-cli) $ mesos-cli-tests
>
>
> Thanks,
>
> Armand Grillet
>
>