You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JiriOndrusek (via GitHub)" <gi...@apache.org> on 2023/02/16 11:58:37 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new issue, #4582: Expand micrometer test coverage
JiriOndrusek opened a new issue, #4582:
URL: https://github.com/apache/camel-quarkus/issues/4582
The following scenarios from the [documentation](https://camel.apache.org/components/3.20.x/micrometer-component.html) are not covered in Camel Quarkus:
- message headers (just increment/decrement for counter and start/stop for timer)
- event notification - cover dump to json
- if possible cover instrumenting thread pool
Because extension leverages quarkus extension (see the [documentaion](https://quarkus.io/guides/micrometer#does-micrometer-support-annotations)) it would be nice to cover major features - it is **optional**.
- try MeterFilter
- annotations
- customized meterRegistry
- microprofile metrics API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on issue #4582: Expand micrometer test coverage
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on issue #4582:
URL: https://github.com/apache/camel-quarkus/issues/4582#issuecomment-1569726819
Is there anyhing more to do here @JiriOndrusek. Can't we perhaps close this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] llowinge commented on issue #4582: Expand micrometer test coverage
Posted by "llowinge (via GitHub)" <gi...@apache.org>.
llowinge commented on issue #4582:
URL: https://github.com/apache/camel-quarkus/issues/4582#issuecomment-1433125354
I've played with the `@Counted` annotation and it looks like the metrics from such method is not exported. Maybe there is some difference between Camel's metrics registry and Quarkus metrics registry. So based on that i would take `microprofile metrics API` as mandatory to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on issue #4582: Expand micrometer test coverage
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on issue #4582:
URL: https://github.com/apache/camel-quarkus/issues/4582#issuecomment-1439959243
Thanks @llowinge for the information. I reported those problems in its own ticket https://github.com/apache/camel-quarkus/issues/4598 and will look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on issue #4582: Expand micrometer test coverage
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on issue #4582:
URL: https://github.com/apache/camel-quarkus/issues/4582#issuecomment-1563954662
Test coverage revealed missing feature `instrumenting core thread pool`. Reported as https://github.com/apache/camel-quarkus/issues/4934.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on issue #4582: Expand micrometer test coverage
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on issue #4582:
URL: https://github.com/apache/camel-quarkus/issues/4582#issuecomment-1445927537
@llowinge I found a reason of different behavior in Quarkus and reported a ticket there - https://github.com/quarkusio/quarkus/issues/31433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton closed issue #4582: Expand micrometer test coverage
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton closed issue #4582: Expand micrometer test coverage
URL: https://github.com/apache/camel-quarkus/issues/4582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on issue #4582: Expand micrometer test coverage
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on issue #4582:
URL: https://github.com/apache/camel-quarkus/issues/4582#issuecomment-1569848410
There will be another PR covering the missing parts. Here is my WIP https://github.com/apache/camel-quarkus/compare/main...JiriOndrusek:CQ4582-expand-micrometer-coverage?expand=1
I hope to finish it this week or the next one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org