You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/07 07:49:20 UTC
[GitHub] [flink] Myasuka opened a new pull request #12835: [hotfix] Fix the typo when describing checkpointed data size
Myasuka opened a new pull request #12835:
URL: https://github.com/apache/flink/pull/12835
## What is the purpose of the change
Fix the typo when describing checkpointed data size
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12835: [hotfix] Fix the typo when describing checkpointed data size
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12835:
URL: https://github.com/apache/flink/pull/12835#issuecomment-654675702
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c77dab5ecfbad386b82f46d8e78d506aea819968",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4290",
"triggerID" : "c77dab5ecfbad386b82f46d8e78d506aea819968",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c77dab5ecfbad386b82f46d8e78d506aea819968 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4290)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12835: [hotfix] Fix the typo when describing checkpointed data size
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12835:
URL: https://github.com/apache/flink/pull/12835#issuecomment-654675702
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c77dab5ecfbad386b82f46d8e78d506aea819968",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4290",
"triggerID" : "c77dab5ecfbad386b82f46d8e78d506aea819968",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c77dab5ecfbad386b82f46d8e78d506aea819968 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4290)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12835: [hotfix] Fix the typo when describing checkpointed data size
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12835:
URL: https://github.com/apache/flink/pull/12835#issuecomment-654675702
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c77dab5ecfbad386b82f46d8e78d506aea819968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c77dab5ecfbad386b82f46d8e78d506aea819968",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c77dab5ecfbad386b82f46d8e78d506aea819968 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka closed pull request #12835: [hotfix] Fix the typo when describing checkpointed data size
Posted by GitBox <gi...@apache.org>.
Myasuka closed pull request #12835:
URL: https://github.com/apache/flink/pull/12835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12835: [hotfix] Fix the typo when describing checkpointed data size
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12835:
URL: https://github.com/apache/flink/pull/12835#issuecomment-654675702
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c77dab5ecfbad386b82f46d8e78d506aea819968",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4290",
"triggerID" : "c77dab5ecfbad386b82f46d8e78d506aea819968",
"triggerType" : "PUSH"
}, {
"hash" : "8d45e6e0c70163279ce8612a1005382f4875cd2d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4300",
"triggerID" : "8d45e6e0c70163279ce8612a1005382f4875cd2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c77dab5ecfbad386b82f46d8e78d506aea819968 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4290)
* 8d45e6e0c70163279ce8612a1005382f4875cd2d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4300)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NicoK commented on a change in pull request #12835: [hotfix] Fix the typo when describing checkpointed data size
Posted by GitBox <gi...@apache.org>.
NicoK commented on a change in pull request #12835:
URL: https://github.com/apache/flink/pull/12835#discussion_r450677726
##########
File path: docs/monitoring/checkpoint_monitoring.md
##########
@@ -61,7 +61,7 @@ The checkpoint history keeps statistics about recently triggered checkpoints, in
- **Trigger Time**: The time when the checkpoint was triggered at the JobManager.
- **Latest Acknowledgement**: The time when the latest acknowledged for any subtask was received at the JobManager (or n/a if no acknowledgement received yet).
- **End to End Duration**: The duration from the trigger timestamp until the latest acknowledgement (or n/a if no acknowledgement received yet). This end to end duration for a complete checkpoint is determined by the last subtask that acknowledges the checkpoint. This time is usually larger than single subtasks need to actually checkpoint the state.
-- **Checkpointed Data Size**: The checkpointed data size over all acknowledged subtasks. This value would be the delta delta checkpointed data if incremetnal checkpoint is on.
+- **Checkpointed Data Size**: The checkpointed data size over all acknowledged subtasks. This value would be the delta checkpointed data if incremetnal checkpoint is on.
Review comment:
```suggestion
- **Checkpointed Data Size**: The checkpointed data size over all acknowledged subtasks. This value represents the delta of the checkpointed data if incremental checkpointing is on.
```
##########
File path: docs/monitoring/checkpoint_monitoring.zh.md
##########
@@ -61,7 +61,7 @@ The checkpoint history keeps statistics about recently triggered checkpoints, in
- **Trigger Time**: The time when the checkpoint was triggered at the JobManager.
- **Latest Acknowledgement**: The time when the latest acknowledged for any subtask was received at the JobManager (or n/a if no acknowledgement received yet).
- **End to End Duration**: The duration from the trigger timestamp until the latest acknowledgement (or n/a if no acknowledgement received yet). This end to end duration for a complete checkpoint is determined by the last subtask that acknowledges the checkpoint. This time is usually larger than single subtasks need to actually checkpoint the state.
-- **Checkpointed Data Size**: The state size over all acknowledged subtasks.
+- **Checkpointed Data Size**: The state size over all acknowledged subtasks. This value would be the delta checkpointed data if incremetnal checkpoint is on.
Review comment:
```suggestion
- **Checkpointed Data Size**: The checkpointed data size over all acknowledged subtasks. This value represents the delta of the checkpointed data if incremental checkpointing is on.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12835: [hotfix] Fix the typo when describing checkpointed data size
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12835:
URL: https://github.com/apache/flink/pull/12835#issuecomment-654675702
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c77dab5ecfbad386b82f46d8e78d506aea819968",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4290",
"triggerID" : "c77dab5ecfbad386b82f46d8e78d506aea819968",
"triggerType" : "PUSH"
}, {
"hash" : "8d45e6e0c70163279ce8612a1005382f4875cd2d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4300",
"triggerID" : "8d45e6e0c70163279ce8612a1005382f4875cd2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d45e6e0c70163279ce8612a1005382f4875cd2d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4300)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12835: [hotfix] Fix the typo when describing checkpointed data size
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12835:
URL: https://github.com/apache/flink/pull/12835#issuecomment-654675702
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c77dab5ecfbad386b82f46d8e78d506aea819968",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4290",
"triggerID" : "c77dab5ecfbad386b82f46d8e78d506aea819968",
"triggerType" : "PUSH"
}, {
"hash" : "8d45e6e0c70163279ce8612a1005382f4875cd2d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8d45e6e0c70163279ce8612a1005382f4875cd2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c77dab5ecfbad386b82f46d8e78d506aea819968 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4290)
* 8d45e6e0c70163279ce8612a1005382f4875cd2d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12835: [hotfix] Fix the typo when describing checkpointed data size
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12835:
URL: https://github.com/apache/flink/pull/12835#issuecomment-654807755
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c77dab5ecfbad386b82f46d8e78d506aea819968 (Tue Jul 07 12:02:04 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12835: [hotfix] Fix the typo when describing checkpointed data size
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12835:
URL: https://github.com/apache/flink/pull/12835#issuecomment-654675702
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c77dab5ecfbad386b82f46d8e78d506aea819968",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4290",
"triggerID" : "c77dab5ecfbad386b82f46d8e78d506aea819968",
"triggerType" : "PUSH"
}, {
"hash" : "8d45e6e0c70163279ce8612a1005382f4875cd2d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4300",
"triggerID" : "8d45e6e0c70163279ce8612a1005382f4875cd2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d45e6e0c70163279ce8612a1005382f4875cd2d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4300)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NicoK commented on pull request #12835: [hotfix] Fix the typo when describing checkpointed data size
Posted by GitBox <gi...@apache.org>.
NicoK commented on pull request #12835:
URL: https://github.com/apache/flink/pull/12835#issuecomment-736524344
@Myasuka sorry for the delay, merging this must have slipped through.
Can you rebase this PR and fir the conflicts? I would then also merge the 1.11 PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #12835: [hotfix] Fix the typo when describing checkpointed data size
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #12835:
URL: https://github.com/apache/flink/pull/12835#issuecomment-654808543
@NicoK Thanks for your kind review, already updated this PR and apply to #12837
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka closed pull request #12835: [hotfix] Fix the typo when describing checkpointed data size
Posted by GitBox <gi...@apache.org>.
Myasuka closed pull request #12835:
URL: https://github.com/apache/flink/pull/12835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org