[jira] [Commented] (DERBY-5014) Tests should restore the timeout values to default after they are done running.

["Tiago R. Espinha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043028#comment-13043028 ] 

Tiago R. Espinha commented on DERBY-5014:
-----------------------------------------

There's something I just noticed and I'd like to clear before committing the patch. There's two more tests that weren't converted nor mentioned here in the comments:

- ResultSetsFromPreparedStatementTest.java
This one seems to have its own mechanism to restore the lock timeout to the default.

Mamta & Knut, did this test get flagged somewhere? On a very quick visual inspection, it seems like the timeouts are restored.

- DatabaseMetaDataTest.java
This test already uses the DatabasePropertyTestSetup decorator. Why was it included in this issue?

> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
>                 Key: DERBY-5014
>                 URL: https://issues.apache.org/jira/browse/DERBY-5014
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.7.1.1
>            Reporter: Mamta A. Satoor
>            Assignee: Siddharth Srivastava
>              Labels: derby_triage10_8
>         Attachments: d5014_1.diff, d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java and ResultSetMiscTest.java as part of DERBY-4273 
> Following are some additional tests that should be fixed 
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java 6)ResultSetsFromPreparedStatementTest.java

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira