You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/11 08:29:44 UTC

[GitHub] [trafficcontrol] dmohan001c commented on a change in pull request #5828: Add TO Client API for Profiles Automation

dmohan001c commented on a change in pull request #5828:
URL: https://github.com/apache/trafficcontrol/pull/5828#discussion_r629959648



##########
File path: traffic_ops/testing/api/v4/profiles_test.go
##########
@@ -238,9 +239,22 @@ func UpdateTestProfiles(t *testing.T) {
 	if err != nil {
 		t.Errorf("cannot GET Profile by name: %v - %v", firstProfile.Name, err)
 	}
+	cdns, _, err := TOSession.GetCDNByName("cdn2", nil)
 	remoteProfile := resp[0]
+	oldName := remoteProfile.Name
+
 	expectedProfileDesc := "UPDATED"
+	expectedCDNId := &cdns[0].ID

Review comment:
       Fixed it.

##########
File path: traffic_ops/testing/api/v4/profiles_test.go
##########
@@ -238,9 +239,22 @@ func UpdateTestProfiles(t *testing.T) {
 	if err != nil {
 		t.Errorf("cannot GET Profile by name: %v - %v", firstProfile.Name, err)
 	}
+	cdns, _, err := TOSession.GetCDNByName("cdn2", nil)
 	remoteProfile := resp[0]
+	oldName := remoteProfile.Name
+
 	expectedProfileDesc := "UPDATED"
+	expectedCDNId := &cdns[0].ID
+	expectedName := "testing"
+	expectedRoutingDisabled := true
+	expectedType := "TR_PROFILE"
+
 	remoteProfile.Description = expectedProfileDesc
+	remoteProfile.Type = expectedType
+	remoteProfile.CDNID = *expectedCDNId

Review comment:
       removed the pointer reference




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org