You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/20 19:50:00 UTC

[jira] [Commented] (GEODE-4133) ClientHealthMonitor.getClientHeartbeats() does not use synchronization

    [ https://issues.apache.org/jira/browse/GEODE-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298989#comment-16298989 ] 

ASF GitHub Bot commented on GEODE-4133:
---------------------------------------

galen-pivotal opened a new pull request #1194: GEODE-4133: synchronize `ClientHealthMonitor.getClientHeartbeats`
URL: https://github.com/apache/geode/pull/1194
 
 
   Add generics and make some things private while I'm at it. eventually maybe we can fix GEODE-2678.
   
   
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [I don't think this is necessary, be] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   
   @WireBaron @PivotalSarge 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ClientHealthMonitor.getClientHeartbeats() does not use synchronization
> ----------------------------------------------------------------------
>
>                 Key: GEODE-4133
>                 URL: https://issues.apache.org/jira/browse/GEODE-4133
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server, messaging
>            Reporter: Galen O'Sullivan
>            Priority: Minor
>
> Access to this collection must be synchronized by a lock, but the method returns a raw reference. It's only used by test code, but it's not marked as a test hook.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)