You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/06/27 02:23:49 UTC
Review Request 23101: Added a default master work directory for local runs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23101/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Bugs: MESOS-1539
https://issues.apache.org/jira/browse/MESOS-1539
Repository: mesos-git
Description
-------
If launching a local cluster and a work directory is not specified in the environment, use a default temporary directory.
Diffs
-----
src/local/local.cpp e05a2250e6960d27794ddcda2f2bf8657e121dd7
Diff: https://reviews.apache.org/r/23101/diff/
Testing
-------
Manual testing with mesos-local.sh.
Thanks,
Ben Mahler
Re: Review Request 23101: Added a default master work directory for local
runs.
Posted by Ben Mahler <be...@gmail.com>.
> On June 27, 2014, 12:44 a.m., Adam B wrote:
> > src/local/local.cpp, line 140
> > <https://reviews.apache.org/r/23101/diff/1/?file=619195#file619195line140>
> >
> > Do we also need to do something for --quorum? Or does that get ignored for mesos-local?
--quorum is an Option so the flag parsing won't complain if it's not present (we explicitly complain inside the master's main.cpp file).
We always pass '1' explicitly into the log constructor for local runs.
> On June 27, 2014, 12:44 a.m., Adam B wrote:
> > src/local/local.cpp, line 143
> > <https://reviews.apache.org/r/23101/diff/1/?file=619195#file619195line143>
> >
> > Should this be more unique? In case we want to launch multiple local masters simultaneously?
mkdtemp will replace XXXXXX to create a unique directory:
http://linux.die.net/man/3/mkdtemp
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23101/#review46822
-----------------------------------------------------------
On June 27, 2014, 12:23 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23101/
> -----------------------------------------------------------
>
> (Updated June 27, 2014, 12:23 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Bugs: MESOS-1539
> https://issues.apache.org/jira/browse/MESOS-1539
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> If launching a local cluster and a work directory is not specified in the environment, use a default temporary directory.
>
>
> Diffs
> -----
>
> src/local/local.cpp e05a2250e6960d27794ddcda2f2bf8657e121dd7
>
> Diff: https://reviews.apache.org/r/23101/diff/
>
>
> Testing
> -------
>
> Manual testing with mesos-local.sh.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 23101: Added a default master work directory for local
runs.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23101/#review46822
-----------------------------------------------------------
Ship it!
Just a couple of questions:
src/local/local.cpp
<https://reviews.apache.org/r/23101/#comment82391>
Do we also need to do something for --quorum? Or does that get ignored for mesos-local?
src/local/local.cpp
<https://reviews.apache.org/r/23101/#comment82390>
Should this be more unique? In case we want to launch multiple local masters simultaneously?
- Adam B
On June 26, 2014, 5:23 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23101/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 5:23 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Bugs: MESOS-1539
> https://issues.apache.org/jira/browse/MESOS-1539
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> If launching a local cluster and a work directory is not specified in the environment, use a default temporary directory.
>
>
> Diffs
> -----
>
> src/local/local.cpp e05a2250e6960d27794ddcda2f2bf8657e121dd7
>
> Diff: https://reviews.apache.org/r/23101/diff/
>
>
> Testing
> -------
>
> Manual testing with mesos-local.sh.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 23101: Added a default master work directory for local
runs.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23101/#review46821
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 27, 2014, 12:23 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23101/
> -----------------------------------------------------------
>
> (Updated June 27, 2014, 12:23 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Bugs: MESOS-1539
> https://issues.apache.org/jira/browse/MESOS-1539
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> If launching a local cluster and a work directory is not specified in the environment, use a default temporary directory.
>
>
> Diffs
> -----
>
> src/local/local.cpp e05a2250e6960d27794ddcda2f2bf8657e121dd7
>
> Diff: https://reviews.apache.org/r/23101/diff/
>
>
> Testing
> -------
>
> Manual testing with mesos-local.sh.
>
>
> Thanks,
>
> Ben Mahler
>
>