You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/05 12:09:42 UTC
[GitHub] [airflow] yingxuanwangxuan opened a new issue, #24844: grid_data api keep refreshing when backfill DAG runs
yingxuanwangxuan opened a new issue, #24844:
URL: https://github.com/apache/airflow/issues/24844
### Apache Airflow version
2.3.2 (latest released)
### What happened
### What you think should happen instead
_No response_
### How to reproduce
_No response_
### Operating System
186-Ubuntu
### Versions of Apache Airflow Providers
2.3.2
### Deployment
Other
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1175721117
What solution do you want other than the already existing ability to manually turn off auto-refresh?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Gollum999 commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
Gollum999 commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1248539373
@potiuk Well, if it were up to me I would just revert the original PR, but that doesn't seem especially productive. :smile:
I was hoping to get some more details from @yingxuanwangxuan (or perhaps @bbovenzi) to better understand the reason behind this change.
Would it help to re-open this thread? Or start a new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1250197724
Looking at this again, maybe we should revert this change. It is possible to turn off auto-refresh when a user doesn't want it. Therefore, the previously functionality is the most flexible for all users. @Gollum999 I'd welcome a PR to change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cloventt commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
cloventt commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1226739950
I'm not sure I understand the reason for this change. Why would you not want the page to auto-refresh? Auto-refresh is useful for seeing the state of running tasks, regardless of whether that task was triggered via a backfill, schedule or manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yingxuanwangxuan commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
yingxuanwangxuan commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1226975552
> I'm not sure I understand the reason for this change. Why would you not want the page to auto-refresh? Auto-refresh is useful for seeing the state of running tasks, regardless of whether that task was triggered via a backfill, schedule or manually.
I am using AirFlow1.10. When I tried to upgrade to a higher version. I found this feature auto-refresh is useful for seeing the state of running tasks. When I backfill my task, the state of these tasks is pending which keeps refreshing.
The airflow Grid page maintains backfilled task state by automatically refreshing whether this is the most appropriate way？ Because the backfill command does not re-run completed DAGs within the given period unless we explicitly instruct it to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bhavaniravi commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
bhavaniravi commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1175066668
@yingxuanwangxuan can you add more info
1. When do you see this error?
2. What should happen instead?
3. How can we reproduce this?
Currently, it looks like the grid view is updating because Auto-refresh is enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yingxuanwangxuan commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
yingxuanwangxuan commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1274339962
I am using AirFlow1.10. When I tried to upgrade to a higher version. I found this feature auto-refresh is useful for seeing the state of running tasks. When I backfill my task, the state of these tasks is pending which keeps refreshing.
The airflow Grid page maintains backfilled task state by automatically refreshing whether this is the most appropriate way？ Because the backfill command does not re-run completed DAGs within the given period unless we explicitly instruct it to do.
| |
hefeixuanzi
|
|
***@***.***
|
On 8/25/2022 11:50，David ***@***.***> wrote：
I'm not sure I understand the reason for this change. Why would you not want the page to auto-refresh? Auto-refresh is useful for seeing the state of running tasks, regardless of whether that task was triggered via a backfill, schedule or manually.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1174985261
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1177797567
Yeah, go for it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yingxuanwangxuan commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
yingxuanwangxuan commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1177148231
> What solution do you want other than the already existing ability to manually turn off auto-refresh?
I'm not sure this is a good solution, can I submit a pr to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi closed issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
bbovenzi closed issue #24844: grid_data api keep refreshing when backfill DAG runs
URL: https://github.com/apache/airflow/issues/24844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Gollum999 commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
Gollum999 commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1238873468
I'm a bit confused by this thread. I have been doing a lot of backfilling recently and I personally find the auto-refresh behavior to be quite useful for monitoring progress. It's still not entirely clear to me what the bug is, but disabling auto-refresh for *all* backfills seems a bit heavy-handed to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cloventt commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
cloventt commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1244781704
I'm in the same camp @Gollum999 , I still can't visualise a situation in which it would be preferred not to automatically refresh the UI when _any_ task or DAG is running/pending, regardless of whether it was started by a backfill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yingxuanwangxuan commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
yingxuanwangxuan commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1175678863
> You can manually click the auto-refresh toggle off to prevent this. Otherwise, those backfilled runs are "pending" and will refresh.
I think this is a problem, can I fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yingxuanwangxuan commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
yingxuanwangxuan commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1175718715
>
> @yingxuanwangxuan can you add more info
>
> 1. When do you see this error?
> 2. What should happen instead?
> 3. How can we reproduce this?
>
> Currently, it looks like the grid view is updating because Auto-refresh is enabled
step1 I schedule DAG（airflow_log_cleanup).
step2 I backfill it.
dags backfill airflow_log_cleanup -s 2022-06-11 -e 2022-06-20 --donot-pickle
step3
I wish it didn't refresh automatically all the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yingxuanwangxuan commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
yingxuanwangxuan commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1175742994
> What solution do you want other than the already existing ability to manually turn off auto-refresh?
in [airflow/www/static/js/grid/api/useGridData.ts] by filter manual and scheduled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1245082868
I would kindly suggest any of the people who are commenting here, on a closed task to submit a PR fixing it. I think there are a number of ways this can be handled - so if any of you has an idea, constructive PR proposing a fix (especially that there is a linked PR that disabled it that can be used as starting point) is much better approach than commenting on a closed issue.
I heartily invite any of you @cloventt @Gollum999 @yingxuanwangxuan to attempt to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #24844: grid_data api keep refreshing when backfill DAG runs
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #24844:
URL: https://github.com/apache/airflow/issues/24844#issuecomment-1175547833
You can manually click the auto-refresh toggle off to prevent this. Otherwise, those backfilled runs are "pending" and will refresh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org