You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Svetlana Samoilenko (JIRA)" <ji...@apache.org> on 2006/05/04 11:55:16 UTC

[jira] Created: (HARMONY-441) [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null

[classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null
--------------------------------------------------------------------------------------------------------------------------------------------------

         Key: HARMONY-441
         URL: http://issues.apache.org/jira/browse/HARMONY-441
     Project: Harmony
        Type: Bug

  Components: Classlib  
    Reporter: Svetlana Samoilenko
    Priority: Minor


According to java 1.5 specification for java.beans.PropertyChangeSupport.addPropertyChangeListener(String propertyName, PropertyChangeListener listener) "If propertyName or listener is null, no exception is thrown and no action is taken".
Harmony throws NPE if propertyName == null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-441) [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-441?page=all ]
     
Mikhail Loenko resolved HARMONY-441:
------------------------------------

    Resolution: Fixed

fixed in revision 399662
Svetlana, please verify that it fully resolves the problem

> [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-441
>          URL: http://issues.apache.org/jira/browse/HARMONY-441
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Svetlana Samoilenko
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: PropertyChangeSupport.diffs
>
> According to java 1.5 specification for java.beans.PropertyChangeSupport.addPropertyChangeListener(String propertyName, PropertyChangeListener listener) "If propertyName or listener is null, no exception is thrown and no action is taken".
> Harmony throws NPE if propertyName == null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-441) [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null

Posted by "Svetlana Samoilenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-441?page=all ]

Svetlana Samoilenko updated HARMONY-441:
----------------------------------------

    Attachment: VetoableChangeSupport.diffs

Mikhail, thanks, the fix looks fine for me.

I also have detected that the same problem is for
VetoableChangeSupport.addVetoableChangeListener((String propertyName,VetoableChangeListener listener) method.

> [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-441
>          URL: http://issues.apache.org/jira/browse/HARMONY-441
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Svetlana Samoilenko
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: PropertyChangeSupport.diffs, VetoableChangeSupport.diffs
>
> According to java 1.5 specification for java.beans.PropertyChangeSupport.addPropertyChangeListener(String propertyName, PropertyChangeListener listener) "If propertyName or listener is null, no exception is thrown and no action is taken".
> Harmony throws NPE if propertyName == null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-441) [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null

Posted by "Svetlana Samoilenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-441?page=all ]

Svetlana Samoilenko updated HARMONY-441:
----------------------------------------

    Attachment: PropertyChangeSupport.diffs

patch and unit test

> [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-441
>          URL: http://issues.apache.org/jira/browse/HARMONY-441
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Svetlana Samoilenko
>     Priority: Minor
>  Attachments: PropertyChangeSupport.diffs
>
> According to java 1.5 specification for java.beans.PropertyChangeSupport.addPropertyChangeListener(String propertyName, PropertyChangeListener listener) "If propertyName or listener is null, no exception is thrown and no action is taken".
> Harmony throws NPE if propertyName == null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-441) [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-441?page=all ]

Mikhail Loenko reassigned HARMONY-441:
--------------------------------------

    Assign To: Mikhail Loenko

> [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-441
>          URL: http://issues.apache.org/jira/browse/HARMONY-441
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Svetlana Samoilenko
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: PropertyChangeSupport.diffs
>
> According to java 1.5 specification for java.beans.PropertyChangeSupport.addPropertyChangeListener(String propertyName, PropertyChangeListener listener) "If propertyName or listener is null, no exception is thrown and no action is taken".
> Harmony throws NPE if propertyName == null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-441) [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-441?page=comments#action_12377950 ] 

Mikhail Loenko commented on HARMONY-441:
----------------------------------------

The second patch was applied in revision 399949

> [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-441
>          URL: http://issues.apache.org/jira/browse/HARMONY-441
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Svetlana Samoilenko
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: PropertyChangeSupport.diffs, VetoableChangeSupport.diffs
>
> According to java 1.5 specification for java.beans.PropertyChangeSupport.addPropertyChangeListener(String propertyName, PropertyChangeListener listener) "If propertyName or listener is null, no exception is thrown and no action is taken".
> Harmony throws NPE if propertyName == null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-441) [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null

Posted by "Svetlana Samoilenko (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-441?page=comments#action_12378184 ] 

Svetlana Samoilenko commented on HARMONY-441:
---------------------------------------------

Mikhail, thank you.
Verified.

> [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-441
>          URL: http://issues.apache.org/jira/browse/HARMONY-441
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Svetlana Samoilenko
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: PropertyChangeSupport.diffs, VetoableChangeSupport.diffs
>
> According to java 1.5 specification for java.beans.PropertyChangeSupport.addPropertyChangeListener(String propertyName, PropertyChangeListener listener) "If propertyName or listener is null, no exception is thrown and no action is taken".
> Harmony throws NPE if propertyName == null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HARMONY-441) [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-441?page=all ]
     
Mikhail Loenko closed HARMONY-441:
----------------------------------


verified by Svetlana

> [classlib] java.beans.PropertyChangeSupport.addPropertyChangeListener(String, PropertyChangeListener) should not throw NPE if propertyName == null
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-441
>          URL: http://issues.apache.org/jira/browse/HARMONY-441
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Svetlana Samoilenko
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: PropertyChangeSupport.diffs, VetoableChangeSupport.diffs
>
> According to java 1.5 specification for java.beans.PropertyChangeSupport.addPropertyChangeListener(String propertyName, PropertyChangeListener listener) "If propertyName or listener is null, no exception is thrown and no action is taken".
> Harmony throws NPE if propertyName == null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira