Re: [PR] Part 1: Log systemName in DataflowWorkUnitClient, Commit, and core worker states [beam]

["rwiggles (via GitHub)" <gi...@apache.org>]

rwiggles commented on code in PR #39561:
URL: https://github.com/apache/beam/pull/39561#discussion_r3708178161


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/DataflowWorkerLoggingHandler.java:
##########
@@ -593,7 +594,7 @@ public synchronized void publishToDisk(
       writeIfNotEmpty(generator, "message", getFormatter().formatMessage(record));
       writeIfNotEmpty(generator, "thread", String.valueOf(record.getThreadID()));
       writeIfNotEmpty(generator, "job", DataflowWorkerLoggingMDC.getJobId());
-      writeIfNotEmpty(generator, "stage", DataflowWorkerLoggingMDC.getStageName());
+      writeIfNotEmpty(generator, "stage", DataflowWorkerLoggingMDC.getSystemStageName());

Review Comment:
   <img width="3302" height="930" alt="image" src="https://github.com/user-attachments/assets/5dad1c20-4c2c-4b9f-8075-2b42e9dea9b1" />
   This doesn't help clear up the records but does at least put the system name in the log details.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org