You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/12/11 10:06:14 UTC
[GitHub] [drill] rajeshguptaiiitm opened a new pull request #2124: DRILL-7094
rajeshguptaiiitm opened a new pull request #2124:
URL: https://github.com/apache/drill/pull/2124
Handling Decimal128 by converting into Double.
# [DRILL-7094](https://issues.apache.org/jira/browse/DRILL-7094): PR Title
(UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards)
## Description
Handling the Decimal128 by converting into Double.
## Documentation
Now Bson Decimal128 type will be handled for the SQL queries and Show the result in double value.
## Testing
Created a Document in Mongo DB with field of Decimal128 type and executing a SQL query using Apache Drill and it return the results. Previously there was a error unsupported Bson Type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2124:
URL: https://github.com/apache/drill/pull/2124#issuecomment-745285676
@rajeshguptaiiitm
You have to be a committer to merge changes. Please squash all commits and set the commit message to
```
DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
```
I'll merge once that's done. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] rajeshguptaiiitm commented on pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
rajeshguptaiiitm commented on pull request #2124:
URL: https://github.com/apache/drill/pull/2124#issuecomment-745307375
Have done it. Kindly merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] rajeshguptaiiitm commented on pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
rajeshguptaiiitm commented on pull request #2124:
URL: https://github.com/apache/drill/pull/2124#issuecomment-745379537
I have done the steps again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2124:
URL: https://github.com/apache/drill/pull/2124#issuecomment-745344717
@rajeshguptaiiitm
I'm not quite sure where the breakdown was. To merge this into Drill, I need one commit with all the changes, with the message that has the PR number and description.
The commands I gave you above should have done exactly what I described. However, we now have 6 commits instead of 1. Can you please take another look and try?
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2124:
URL: https://github.com/apache/drill/pull/2124#issuecomment-745433908
@rajeshguptaiiitm
I'm not sure what you're doing at this point, but I'd recommend starting a new branch with just the files you've modified. I'm not a git expert, so that's the best advice I can give at this point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2124:
URL: https://github.com/apache/drill/pull/2124#issuecomment-745389808
@rajeshguptaiiitm
I'm not sure what you did, but now there are 59 files modified. Can you please revert this and try again? The goal is to have one single commit with your specific changes (and only those changes). This commit now includes a bunch of commits that are not related to this PR.
Just to be clear this command `git reset --soft HEAD~4` the `4` refers to the number of commits you are squashing, so that can change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2124:
URL: https://github.com/apache/drill/pull/2124#issuecomment-743380011
@rajeshguptaiiitm
Thank you for the contribution. Could you add a unit test for this fix?
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2124:
URL: https://github.com/apache/drill/pull/2124#issuecomment-744650052
LGTM +1
Thanks for the contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2124:
URL: https://github.com/apache/drill/pull/2124#issuecomment-745434383
@rajeshguptaiiitm
I'm not sure what you did but we're not getting the results we're looking for. The commit that will get merged must have:
* A single commit with the code you modified and nothing else
* A commit message with the pull request number and description
Once we're there, I am happy to merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] rajeshguptaiiitm commented on pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
rajeshguptaiiitm commented on pull request #2124:
URL: https://github.com/apache/drill/pull/2124#issuecomment-745440522
Now it is all set to go
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2124:
URL: https://github.com/apache/drill/pull/2124#issuecomment-745310991
@rajeshguptaiiitm
The commits are not squashed. There should be only 1 commit.
The way to do this is:
```
git reset --soft HEAD~4
git commit -m "DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards"
git push origin +master
```
Please verify your branch BEFORE executing the last step.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] rajeshguptaiiitm commented on pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
rajeshguptaiiitm commented on pull request #2124:
URL: https://github.com/apache/drill/pull/2124#issuecomment-745332113
Now I have done the described steps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] rajeshguptaiiitm commented on pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
rajeshguptaiiitm commented on pull request #2124:
URL: https://github.com/apache/drill/pull/2124#issuecomment-745147234
Hi,
Could you please tell me how can I merge these changes because merge option is not available for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2124:
URL: https://github.com/apache/drill/pull/2124#issuecomment-745458494
@rajeshguptaiiitm
Thanks for your work on this. I know working with git can be challenging. We're almost there. Unfortunately, there are still some extra files in the most recent commit. Can you please make sure that the commit only has the changes from this PR and we'll get it merged.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] rajeshguptaiiitm closed pull request #2124: DRILL-7094: UnSupported Bson type: DECIMAL128 Mongodb 3.6 onwards
Posted by GitBox <gi...@apache.org>.
rajeshguptaiiitm closed pull request #2124:
URL: https://github.com/apache/drill/pull/2124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org